[Bug 7967] New: Z39.50 client should negotiate encoding with server
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Priority: P5 - low Change sponsored?: --- Bug ID: 7967 Assignee: gmcharlt@gmail.com Summary: Z39.50 client should negotiate encoding with server QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: pongtawat.c@gmail.com Hardware: All Status: NEW Version: rel_3_2 Component: Cataloging Product: Koha Created attachment 9216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9216&action=edit Add UTF-8 charset negotiation to Z39.50 search Currently Koha has an option to specify encoding for Z39.50 target. However, that option only tell Koha what encoding is to be expected from the server. Some server support multiple encoding format that could be negotiated via "charset" option. For example OCLC WorldCat support both UTF-8 and MARC-8 and default to MARC-8. As UTF-8 should be a better option, it would be better if Koha can try to negotiate the result encoding. I made a simple patch to z3950_search.pl that just set ZOOM charset option to 'UTF-8" when Koha's Z39.50 target encoding is set to utf8 (I don't know valid value for charset option for other encoding). This work for OCLC WorldCat and some other targets. Note that I test it on Koha 3.2 and it should also work on later version as that part of code is unchanged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9216|0 |1 is obsolete| | --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9222&action=edit Bug 7967 - set charset when doing Z39.50 search Original patch from Pongtawat -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 --- Comment #2 from Pongtawat <pongtawat.c@gmail.com> --- Created attachment 9250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9250&action=edit set charste for Z39.50 in acquision -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 --- Comment #3 from Pongtawat <pongtawat.c@gmail.com> --- I just notice that there is another Z39.50 client code in acquision that should also be updated (acqui/z3950_search.pl). I think it should be included in the patch (but I don't know how). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9250|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9667&action=edit Bug 7967 : Followup set encoding options for acqui/z3950_search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Can we get a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |pongtawat.c@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #6 from Magnus Enger <magnus@enger.priv.no> --- The code that these patches touched has been moved to C4::Breeding (and concolidated into a single function) by bug 9105. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 --- Comment #7 from Pongtawat <pongtawat.c@gmail.com> --- I just found that setting this charset option broke some Z39.50 servers. For example, for OhioLink server, it will freeze. Horizon Z39.50 server here seem to not like it either. So, it shouldn't be set unless needed. Since I need to set this option for OCLC to work properly for Thai language, so locally, I just hacked it to have a new option "UTF-8 with negotiation" to do this. Since it seems no one else has this problem, maybe the code should be leave as-is and this bug closed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org