[Bug 23215] New: Remove PayPal logic from Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Bug ID: 23215 Summary: Remove PayPal logic from Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org Depends on: 23118 Target Milestone: --- PayPal should be treated as any other payment plugin, to unify treatment of payment methods. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23118 [Bug 23118] Copy PayPal logic into plugin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Bug 23215 depends on bug 23118, which changed state. Bug 23118 Summary: Create a plugin to implement the PayPal payments logic https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23118 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we might want to do some deprecation steps here first. Suggestion, for 20.11: - Deprecate the plugin in the release notes - Add information about deprecation to the Paypal system preferences - Add an entry to the "system information" tab For 21.05: - Remove the code and enforce the switch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Where are we here? Should the deprecation be announced in 20.11? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I wonder if we aught to either grab the plugin as part of the upgrade if the syprefs are set.. or at the very least highlight to the user as upgrade time that they'll need to grab the plugin.. (and make sure we copy the config to somewhere so they can easily use it in the plugin config when they come to use that route) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Lets put a bold message about it being deprecated, in the release notes, and the about page!. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #1)
I think we might want to do some deprecation steps here first.
Suggestion, for 20.11: - Deprecate the plugin in the release notes - Add information about deprecation to the Paypal system preferences - Add an entry to the "system information" tab
For 21.05: - Remove the code and enforce the switch
^^ 100% agree with that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #5)
(In reply to Katrin Fischer from comment #1)
I think we might want to do some deprecation steps here first.
Suggestion, for 20.11: - Deprecate the plugin in the release notes - Add information about deprecation to the Paypal system preferences - Add an entry to the "system information" tab
For 21.05: - Remove the code and enforce the switch
^^ 100% agree with that
Do you have time to do it? A few more strings are not bad right now, but should be added very soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27044 [Bug 27044] Deprecate core support for PayPal payments -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target |rel_21_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can we have a patch please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120519&action=edit Bug 23215: Remove PayPal-related sysprefs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
SELECT * FROM systempreferences WHERE variable LIKE 'paypal'; => SUCCESS: No results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120520&action=edit Bug 23215: Remove traces of the PayPal feature This patch removes the PayPal payments feature. It has been moved to its' own plugin. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: Database updates correctly 3. Run: $ koha-mysql kohadev 4. On the sysprefs, OPAC section => SUCCESS: No PayPal-related sysprefs show up 5. Add some charges to your patron 6. In the OPAC, log in and see your charges => SUCCESS: Nothing broken 7. Install the PayPal plugin [1] or any other payment plugin 8. Restart plack (mandatory for the PayPal plugin) 9. Set some random data in the config (or better, real sandbox testing data) 10. Go to the OPAC's account page and try to pay your debts (use the checkbox to select lines) => SUCCESS: The PayPal payment method shows, you can click the button, it fails due to bad config, but things work as expected. 11. Sign off :-D [1] https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/relea... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120519|0 |1 is obsolete| | Attachment #120520|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120634&action=edit Bug 23215: Remove PayPal-related sysprefs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120634|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120635&action=edit Bug 23215: Remove PayPal-related sysprefs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
SELECT * FROM systempreferences WHERE variable LIKE 'paypal'; => SUCCESS: No results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120636&action=edit Bug 23215: Remove traces of the PayPal feature This patch removes the PayPal payments feature. It has been moved to its' own plugin. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: Database updates correctly 3. Run: $ koha-mysql kohadev 4. On the sysprefs, OPAC section => SUCCESS: No PayPal-related sysprefs show up 5. Add some charges to your patron 6. In the OPAC, log in and see your charges => SUCCESS: Nothing broken 7. Install the PayPal plugin [1] or any other payment plugin 8. Restart plack (mandatory for the PayPal plugin) 9. Set some random data in the config (or better, real sandbox testing data) 10. Go to the OPAC's account page and try to pay your debts (use the checkbox to select lines) => SUCCESS: The PayPal payment method shows, you can click the button, it fails due to bad config, but things work as expected. 11. Sign off :-D [1] https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/relea... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Moving to Passed QA. RM can ask for another signer if need be. I tested thoroughly. Test end-to-end functionality with the PayPal plugin, which went perfectly. Also installed other plugins to ensure they continued to function, which they did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |sandboxes@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Release notes needed for 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A while ago, a new paypemnt release notes| |plugin for PayPal was | |introduced, with more | |features like per-branch | |configurations. [1] | | | |This | |patch removes the PayPal | |payment feature from the | |codebase in favor of that | |plugin. | | | |[1] | |https://gitlab.com/thekesol | |utions/plugins/koha-plugin- | |pay-via-paypal Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|A while ago, a new paypemnt |A while ago, a new payment release notes|plugin for PayPal was |plugin for PayPal was |introduced, with more |introduced, with more |features like per-branch |features like per-branch |configurations. [1] |configurations. [1] | | |This |This |patch removes the PayPal |patch removes the PayPal |payment feature from the |payment feature from the |codebase in favor of that |codebase in favor of that |plugin. |plugin. | | |[1] |[1] |https://gitlab.com/thekesol |https://gitlab.com/thekesol |utions/plugins/koha-plugin- |utions/plugins/koha-plugin- |pay-via-paypal |pay-via-paypal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088 [Bug 36088] Remove useless code form opac-account-pay.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org