https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39770 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 181640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181640&action=edit Bug 39770: Fix wrong Braille format search for Elasticsearch ElasticSearch couldn't find any books that have Braille: No results match your search with limit(s): 'ff7-01-02:("tc or fb")'. It was a problem because the "l-format:tc or fb" only works for Zebra and is incorrect way to search with OR for ElasticSearch. Elastic requires the syntax to be l-format:"tc" OR "fb” (uppercase OR and each format in double quotes) instead. This patch fixes it by checking which search engine you use depending on the current syspref SearchEngine and provides the correctly formatted format. To reproduce: 1. Have ElasticSearch enabled and check that you have books with braille, or make up one yourself by adding "tc" (text - Braille) or "fb" (tactile material - braille) to 007 MARC field. 2. Go to catalogue/advanced search and select format: braille, from the dropdown. 3. Try to find anything, if you are using ElasticSearch you will see: No results match your search with limit(s): 'ff7-01-02:("tc or fb")' 4. Do the same with Zebra instead of Elastic, it should work properly and you should see all the books that have Braille. 5. Apply the patch. 6. Repeat same search both using ElasticSearch and then Zebra. Both ElasticSearch and Zebra should work without any issues. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do we really need the check on SearchEngine here? AFAIK Zebra also works with both upper and lower case boolean, so we could just switch this like we did in other places? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39770 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Peter Vashchuk from comment #3)

Unfortunately, yes, because it's not just about the OR being upper case, Elasticsearch needs the terms to be quoted like: "tc" OR "fb", to parse them properly, otherwise it treats it as a singular term "tc OR fb" and finds nothing.

Thanks for explaining :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39770 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lin-wei.li@inLibro.com --- Comment #5 from Lin Wei <lin-wei.li@inLibro.com> --- # Test Results - ElasticSearch: Expected behavior. - Zebra: Does not work. # Test Execution 0. Create new Catalog with "fb" in 007. 1. Advanced search > Subtype limits > Format > Braille (Default search engine: ElasticSearch). 2. No results match your search with limit(s): 'ff7-01-02:("tc or fb")'. 3. Switch search engine to Zebra. 4. No results match your search with limit(s): 'l-format:tc or fb'. 5. Apply patch. 6. No results match your search with limit(s): 'l-format:tc or fb'. 7. Switch search engine back to ElasticSearch. 8. ElasticSearch finds my Catalog. # Notes - Zebra seems to not work at all for me (even on simple searches that I know should work), so it's likely be a problem on my end. - I can sign-off for ElasticSearch, but I don't know for Zebra. - Someone else might be able to verify that Zebra still works with Braille after the patch. - I will leave the status as "Needs Signoff." -- You are receiving this mail because: You are watching all bug changes.