https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186262&action=edit Bug 40769: Display hold fees in staff client when placing holds This patch adds hold fee information display in the staff client's hold request interface, bringing it to feature parity with the OPAC. The OPAC already shows patrons the fee that will be charged for placing a hold, but the staff client did not display this information when staff place holds on behalf of patrons. This creates a transparency gap where staff cannot inform patrons about potential charges. Changes: - Import GetReserveFee function in reserve/request.pl - Calculate reserve charges for each biblio record - Display fee information in both single and multi-hold interfaces - Show appropriate messaging based on HoldFeeMode system preference - Use consistent formatting with currency display Test Plan: 1. Set up hold fees: - Go to Administration > Patron categories - Edit a patron category and set a "Hold fee" (e.g., 1.00) - Ensure HoldFeeMode system preference is set (default: "only if all items are checked out and the record has at least one") 2. Test single hold with fee display: - Go to a bibliographic record - Click "Place hold" - Find a patron from the category with hold fees configured - Verify fee information displays after the title: * Shows "Note: [Patron Name] will be charged a hold fee of $1.00 for placing this hold" when the HoldFeeMode is set to "any time a hold is placed" * Or "...when they collect this item" if HoldFeeMode is set to "any time a hold is collected" 3. Test multi-hold with fee display: - Ensure 'DisplayMultiPlaceHold' preference is set to 'Enable' - Search the catalog - On the search results page, select multiple biblios and click 'Place hold' - Search for the same patron - In the confirmation table, verify each record shows: * "Hold fee: $1.00 (charged when placed)" in the Information column * Or "(charged when collected)" based on HoldFeeMode 4. Test no fee display: - Repeat tests with a patron from a category with no hold fee - Verify no fee information is displayed 5. Test different HoldFeeMode settings: - Change HoldFeeMode system preference to 'any_time_is_collected' - Verify messaging changes to "when they collect this item" - Test with 'not_always' mode and verify fee only shows when appropriate 6. Verify existing functionality: - Ensure hold placement still works normally - Verify all other hold interface elements remain unchanged - Test that holds are properly placed with or without fees -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |lucy.vaux-harvey@openfifth. | |co.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40808 [Bug 40808] Holds charges should be accessible from Holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40808 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186262|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190934&action=edit Bug 40769: Display hold fees in staff client when placing holds This patch adds hold fee information display in the staff client's hold request interface, bringing it to feature parity with the OPAC. The OPAC already shows patrons the fee that will be charged for placing a hold, but the staff client did not display this information when staff place holds on behalf of patrons. This creates a transparency gap where staff cannot inform patrons about potential charges. Changes: - Import GetReserveFee function in reserve/request.pl - Calculate reserve charges for each biblio record - Display fee information in both single and multi-hold interfaces - Show appropriate messaging based on HoldFeeMode system preference - Use consistent formatting with currency display Test Plan: 1. Set up hold fees: - Go to Administration > Patron categories - Edit a patron category and set a "Hold fee" (e.g., 1.00) - Ensure HoldFeeMode system preference is set (default: "only if all items are checked out and the record has at least one") 2. Test single hold with fee display: - Go to a bibliographic record - Click "Place hold" - Find a patron from the category with hold fees configured - Verify fee information displays after the title: * Shows "Note: [Patron Name] will be charged a hold fee of $1.00 for placing this hold" when the HoldFeeMode is set to "any time a hold is placed" * Or "...when they collect this item" if HoldFeeMode is set to "any time a hold is collected" 3. Test multi-hold with fee display: - Ensure 'DisplayMultiPlaceHold' preference is set to 'Enable' - Search the catalog - On the search results page, select multiple biblios and click 'Place hold' - Search for the same patron - In the confirmation table, verify each record shows: * "Hold fee: $1.00 (charged when placed)" in the Information column * Or "(charged when collected)" based on HoldFeeMode 4. Test no fee display: - Repeat tests with a patron from a category with no hold fee - Verify no fee information is displayed 5. Test different HoldFeeMode settings: - Change HoldFeeMode system preference to 'any_time_is_collected' - Verify messaging changes to "when they collect this item" - Test with 'not_always' mode and verify fee only shows when appropriate 6. Verify existing functionality: - Ensure hold placement still works normally - Verify all other hold interface elements remain unchanged - Test that holds are properly placed with or without fees Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190934|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190945&action=edit Bug 40769: Display hold fees in staff client when placing holds This patch adds hold fee information display in the staff client's hold request interface, bringing it to feature parity with the OPAC. The OPAC already shows patrons the fee that will be charged for placing a hold, but the staff client did not display this information when staff place holds on behalf of patrons. This creates a transparency gap where staff cannot inform patrons about potential charges. Changes: - Import GetReserveFee function in reserve/request.pl - Calculate reserve charges for each biblio record - Display fee information in both single and multi-hold interfaces - Show appropriate messaging based on HoldFeeMode system preference - Use consistent formatting with currency display Test Plan: 1. Set up hold fees: - Go to Administration > Patron categories - Edit a patron category and set a "Hold fee" (e.g., 1.00) - Ensure HoldFeeMode system preference is set (default: "only if all items are checked out and the record has at least one") 2. Test single hold with fee display: - Go to a bibliographic record - Click "Place hold" - Find a patron from the category with hold fees configured - Verify fee information displays after the title: * Shows "Note: [Patron Name] will be charged a hold fee of $1.00 for placing this hold" when the HoldFeeMode is set to "any time a hold is placed" * Or "...when they collect this item" if HoldFeeMode is set to "any time a hold is collected" 3. Test multi-hold with fee display: - Ensure 'DisplayMultiPlaceHold' preference is set to 'Enable' - Search the catalog - On the search results page, select multiple biblios and click 'Place hold' - Search for the same patron - In the confirmation table, verify each record shows: * "Hold fee: $1.00 (charged when placed)" in the Information column * Or "(charged when collected)" based on HoldFeeMode 4. Test no fee display: - Repeat tests with a patron from a category with no hold fee - Verify no fee information is displayed 5. Test different HoldFeeMode settings: - Change HoldFeeMode system preference to 'any_time_is_collected' - Verify messaging changes to "when they collect this item" - Test with 'not_always' mode and verify fee only shows when appropriate 6. Verify existing functionality: - Ensure hold placement still works normally - Verify all other hold interface elements remain unchanged - Test that holds are properly placed with or without fees Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 [Bug 40817] Holds charges should be accessible from Holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds hold fee |This enhancement adds hold release notes|information display in the |fee information display in |staff client's hold |the staff interface's hold |request interface, bringing |request interface, bringing |it to feature parity with |it to feature parity with |the OPAC. |the OPAC. | | |The OPAC already shows |The OPAC already shows |patrons the fee that will |patrons the fee that will |be charged for placing |be charged for placing |a hold, but the staff |a hold, but the staff |client did not display this |interface did not display |information when staff |this information when staff |place holds on behalf of |place holds on behalf of |patrons. This creates a |patrons. This creates a |transparency gap where |transparency gap where |staff cannot inform patrons |staff cannot inform patrons |about potential charges. |about potential charges. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.