[Bug 16007] New: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Bug ID: 16007 Summary: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: charles.farmer@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This seems to be a mistake, since we only dropped columns `branchcode` and `categorycode` in the atomicupdate file. This new bug is to keep track of everything made to address this issue. I don't know if we'll start with a patch correcting the master, or if we'll rebase to old patch and move from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |charles.farmer@inlibro.com |y.org | Assignee|gmcharlt@gmail.com |charles.farmer@inlibro.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13624 CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Charles Farmer from comment #0)
I don't know if we'll start with a patch correcting the master, or if we'll rebase to old patch and move from there.
Start from master. It's easier for people to test from that point. :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 [Bug 12772] Overdue Notice/Status triggers tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Any progress on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #3 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Katrin Fischer from comment #2)
Any progress on this?
Not yet. I'll try to make a patch in-between two tasks soon enough -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 49398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49398&action=edit Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 49398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49398 Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Review of attachment 49398: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16007&attachment=49398) ----------------------------------------------------------------- Take a look at C4/Members.pm sub columns. I think that is a better way to determine column names. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49398|0 |1 is obsolete| | --- Comment #6 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 49401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49401&action=edit Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to M. Tompsett from comment #5)
Take a look at C4/Members.pm sub columns. I think that is a better way to determine column names. :)
That's a much cleaner, less db-dependent way of doing it. I obsoleted my last patch and made a new one. Reviews are welcomed, as always. If I ever fix the patch in 13624, should I post it back there again, somewhere here on this bug, or should we open a new tracker? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 49401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49401 Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Review of attachment 49401: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16007&attachment=49401) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl @@ +23,5 @@
+ { + $letternumberExists = 1; + last; + } + }
While this would work. Why not use grep? my @letternumber = grep { $_ eq 'letternumber' } @data; if (@letternumber) { print "EXISTS!\n"; } else { print "DIDN'T FIND!\n"; } http://perldoc.perl.org/functions/grep.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to M. Tompsett from comment #8)
While this would work. Why not use grep?
Silly java coding weekend, why do you make me forget about grep :( Do you want another patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Charles Farmer from comment #9)
Do you want another patch?
If you don't mind, that would be nicer. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49401|0 |1 is obsolete| | --- Comment #11 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 49402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49402&action=edit Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49402|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49403&action=edit Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49404&action=edit Schema update In case it is needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #14 from Charles Farmer <charles.farmer@inlibro.com> --- The previous patch, from 13624, has yet to be corrected. How do I go about this? New tracker, or new patche in #13624 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Charles Farmer from comment #14)
The previous patch, from 13624, has yet to be corrected.
How do I go about this? New tracker, or new patche in #13624 ?
13624 is already pushed to master, just wait for this to pass QA and then get pushed. I don't think there is a need to touch 13624 at all. I'm sure a QA person can comment more authoritatively. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49455&action=edit Bug 16007: Simplify the DB entry - No need to check if the table exists - No need to check if the column exists, just remove the warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The DB entry is very complicated. I have attached a patch to simplify it. Letting another QAer to have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical QA Contact|charles.farmer@inlibro.com |testopia@bugs.koha-communit | |y.org --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upgrading the severity, we need it asap! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49404|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 49404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49404 Schema update No needed, it's the RM job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49403|0 |1 is obsolete| | Attachment #49455|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49514&action=edit [PASSED QA] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested with and without the column in the database - database update didn't throw an error and table was corrected. Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49515&action=edit [PASSED QA] Bug 16007: Simplify the DB entry - No need to check if the table exists - No need to check if the column exists, just remove the warning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #23 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org