[Bug 18369] New: Broken title link in UNIMARC catalog search results table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Bug ID: 18369 Summary: Broken title link in UNIMARC catalog search results table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: synapse.ova@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In staff client, «Search the catalog» returns a table, where biblio title has a broken link (biblionumber is absent), yet other links works good (Holds, Edit Record, Edit items, OPAC view) Steps to Reproduce: In staff client, search the catalog (Cataloging → «Search the catalog» (/cgi-bin/koha/catalogue/search.pl)) Actual Results: Title of the biblio has a link, that doesn't have biblionumber Expected Results: Title of the biblio should have a link with a proper biblionumber at the end Additional Information: Each biblio in the results table is shown by XSL transformation of MARC data. XSL (\intranet-tmpl\prog\en\xslt\UNIMARCslim2intranetResults.xsl) prepares a link, and adds a biblionumber, that it expects to get from controlfield 001. But since this field could be either empty or contain something different than biblionumber (see https://lists.katipo.co.nz/public/koha/2015-September/043652.html), it is better to pass the biblionumber to this script. This script is already receiving sysprefs (that is not according to marcxml standart), so I suggest to pass the biblionumber the same way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Oleg Vasilenko <synapse.ova@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |synapse.ova@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Oleg Vasilenko <synapse.ova@gmail.com> --- Created attachment 61793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61793&action=edit Bug 18369: Broken title link in UNIMARC catalog search results table Patch adds biblionumber to XSLT the same way Sysprefs are added, in the C4/XSLT.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Oleg Vasilenko <synapse.ova@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17730 --- Comment #2 from Oleg Vasilenko <synapse.ova@gmail.com> --- This problem happens in 16.05+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- I tried to reproduce this error, and couldn't. I'm running UNIMARC, default XSLT, and the links are working fine (master branch) There's probably another specific parameter to see the bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #4 from Oleg Vasilenko <synapse.ova@gmail.com> --- This bug will reveal itself if record has empty 001, or 001 is not biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- In my setup, the biblionumber is in 001, this explain that (can't sign-off this patch, but OTOH, won't failed QA it either ;-) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think in the french UNIMARC installer everything is set up for 001 = biblionumber. I am not sure if having the bilbionumber stored elseqhere in a UNIMARC setup won't cause you more trouble overall. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |julian.maurice@biblibre.com Status|Needs Signoff |In Discussion --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still think that changing the default mapping of the biblionumber is quite dangerous. You'd also have to adjust your indexing and possibly see problems in some other spots. Setting this to 'In Discussion', and cc'ing some UNIMARC experts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Katrin, it's not changing the default mapping, it's just removing a hardcoding of biblionumber in 001 in XSLT Instead of building the biblionumber from hardcoded 001 field, this patch send $biblionumber to the XSL, and uses it where needed : Send the biblionumber as parameter: + my $kohavars = "<koha>\n<biblionumber>$biblionumber</biblionumber>\n</koha>\n"; Instead of 001, us the $biblionumber: - <xsl:variable name="biblionumber" select="marc:controlfield[@tag=001]"/> + <xsl:variable name="biblionumber" select="marc:koha/marc:biblionumber"/> PS: not sure the patch is perfect, complete or valid. But I 100% agree with the fact that we must not assume that biblionumber is in 001. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know, but should we encourage changing the UNIMARC default mapping, when the index for biblionumber etc will be wrong if you do that? If we are not supporting the use case, we should not start adding code to work around it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis@dataly.gr Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #10 from George Veranis <gveranis@dataly.gr> --- *** This bug has been marked as a duplicate of bug 22969 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org