[Bug 17297] New: Give librarians the ability to add messages to an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Bug ID: 17297 Summary: Give librarians the ability to add messages to an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 13733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55544&action=edit Bug 17297 - Add npm and webpack config files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55545&action=edit Bug 17297 [POC] - Add React based item message editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55546&action=edit Bug 17297 [POC] - Add minified js file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch set is a proof of concept for using React for the item messages editor. It has no backend at the moment. It will be trivial to hook this widget into the REST API once the concept is approved. If you want to try it out: 1) Apply this patch set 2) Browse to moredetail.pl 3) Note each item has the same 5 pre-generated item messages 4) Test Adding and removing item messages If you want to hack on it: 1) Install npm 2) Apply this patch set 3) Run 'npm -i' to install development dependencies 4) Run 'webpack' to update the compiled moremember.js file to the dev version of React 5) Hack on it, run 'webpack' after making changes ( or look at the --watch option ) 6) Run webpack -p --config webpack-production.config.js to minify the moremember.js file before submitting an update to it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18098 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18098 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55544|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60861&action=edit [SIGNED-OFF] Bug 17297 - Add npm and webpack config files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55545|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60862&action=edit [SIGNED-OFF] Bug 17297 [POC] - Add React based item message editor Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55546|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60863&action=edit [SIGNED-OFF] Bug 17297 [POC] - Add minified js file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17361 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 [Bug 17361] Add item messages table and rest api endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60861|0 |1 is obsolete| | Attachment #60862|0 |1 is obsolete| | Attachment #60863|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60926&action=edit Bug 17297 - Add npm and webpack config files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60927&action=edit Bug 17297 - Add React based item message editor Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60928&action=edit Bug 17297 - Add minified js file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Failed QA --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Just few things, qa tools complain: FAIL catalogue/moredetail.pl FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 268) And the test plan does not mention the need of ITEM_MESSAGE_TYPE authorised values category. The input field get's smaller when I start to write a message. Maybe the trash icon would be better for removing messages... Do you have plan to show some messages summary information on normal detail page? Failed QA because of the usage of Data::Dumper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Bug 17297 depends on bug 17361, which changed state. Bug 17361 Summary: Add item messages table and rest api endpoints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27374 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this was probably closed because of the React POC? Because I think the feature itself would still be very useful, I have re-filed a new enh. request: bug 27374 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #13)
I think this was probably closed because of the React POC? Because I think the feature itself would still be very useful, I have re-filed a new enh. request: bug 27374
Both of those bugs patches are quite old at this point. We needed this feature post-haste and since we are still in the process of settling the react/vue debate, I created a plugin as a stop-gap: https://github.com/bywatersolutions/koha-plugin-item-messages We should consider this as a possibility for Koha, it is react based but requires no backend transpiling! In theory the same could be done for vue if that's what we go with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Bug 17297 depends on bug 17361, which changed state. Bug 17361 Summary: Add item messages table and rest api endpoints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org