[Bug 6379] New: Remove link from unapproved and rejected tags in the OPAC's "My tags" table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bug #: 6379 Summary: Remove link from unapproved and rejected tags in the OPAC's "My tags" table Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/opac-tags.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org You can't perform a search of the catalog using unapproved or rejected tags, so the table of the user's tags should not have clickable links for them. There should probably be additional visual feedback to indicate why the term isn't clickable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-02 03:20:41 UTC --- Created attachment 5266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5266 Bug 6739 : Funds not showing up for super librarians -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-02 03:25:42 UTC --- The content of attachment 5266 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2011-09-02 15:25:38 NZST. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 10815 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37211&action=edit Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 37222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37222&action=edit [Signed-off] Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. Works as expected. Unapproved tags in column 'Terms' are not linked and are marked with (not approved) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37211|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am sorry, but with the patch applied I have problems adding new tags, this is after trying form the result list: [Wed Mar 25 22:07:32.575073 2015] [cgi:error] [pid 18931] [client 127.0.0.1:59595] AH01215: [Wed Mar 25 22:07:32 2015] opac-tags.pl: DBD::mysql::st execute failed: Column 'term' in where clause is ambiguous at /home/katrin/kohaclone/C4/Tags.pm line 221., referer: http://localhost/cgi-bin/koha/opac-search.pl?idx=kw&q=der&sort_by=relevance&addto=Add+to...&tagsel_new=&biblionumber=2&loggedinuser=&newtag2=XXX&biblionumber=4&loggedinuser=&newtag4=&biblionumber=8&loggedinuser=&newtag8=&biblionumber=9&loggedinuser=&newtag9=&biblionumber=10&loggedinuser=&newtag10=&biblionumber=13&loggedinuser=&newtag13=&biblionumber=14&loggedinuser=&newtag14=&biblionumber=18&loggedinuser=&newtag18=&biblionumber=19&loggedinuser=&newtag19=&biblionumber=23&loggedinuser=&newtag23=&biblionumber=32&loggedinuser=&newtag32=&biblionumber=38&loggedinuser=&newtag38=&biblionumber=40&loggedinuser=&newtag40=&biblionumber=47&loggedinuser=&newtag47=&biblionumber=50&loggedinuser=&newtag50=&biblionumber=58&loggedinuser=&newtag58=&biblionumber=60&loggedinuser=&newtag60=&biblionumber=61&loggedinuser=&newtag61=&biblionumber=63&loggedinuser=&newtag63=&biblionumber=64&loggedinuser=&newtag64= [Wed Mar 25 22:07:32.575440 2015] [cgi:error] [pid 18931] [client 127.0.0.1:59595] AH01215: [Wed Mar 25 22:07:32 2015] opac-tags.pl: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2064., referer: http://localhost/cgi-bin/koha/opac-search.pl?idx=kw&q=der&sort_by=relevance&addto=Add+to...&tagsel_new=&biblionumber=2&loggedinuser=&newtag2=XXX&biblionumber=4&loggedinuser=&newtag4=&biblionumber=8&loggedinuser=&newtag8=&biblionumber=9&loggedinuser=&newtag9=&biblionumber=10&loggedinuser=&newtag10=&biblionumber=13&loggedinuser=&newtag13=&biblionumber=14&loggedinuser=&newtag14=&biblionumber=18&loggedinuser=&newtag18=&biblionumber=19&loggedinuser=&newtag19=&biblionumber=23&loggedinuser=&newtag23=&biblionumber=32&loggedinuser=&newtag32=&biblionumber=38&loggedinuser=&newtag38=&biblionumber=40&loggedinuser=&newtag40=&biblionumber=47&loggedinuser=&newtag47=&biblionumber=50&loggedinuser=&newtag50=&biblionumber=58&loggedinuser=&newtag58=&biblionumber=60&loggedinuser=&newtag60=&biblionumber=61&loggedinuser=&newtag61=&biblionumber=63&loggedinuser=&newtag63=&biblionumber=64&loggedinuser=&newtag64= -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37222|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37259&action=edit Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
Hm, I am sorry, but with the patch applied I have problems adding new tags, this is after trying form the result list:
Thanks for catching that! My error was to try to modify C4::Tags, it's a nightmare. This last patch does what I tried to do but without modifingy the module. It's less efficient but much more safe. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, tested and works. One problem, when I click on tag's link, I got a no results found, and "Can't locate YAML/XS.pm in @INC..." Installing YAML::XS (using cpan) solves the problem, but can't understand what is calling or ising that library, and is not a Koha dep. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37259|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39088&action=edit [SIGNED-OFF] Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> works as described, no errors For the (approved) link to work I need to install YAML::XS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I have added three tags with a normal user: Biblio 1: tag1 tag2 Biblio 2: tag1 I have approved tag1 in staff, did not touch tag2. I see the tag1 in opac-detail. I can click on it and have two results. With the normal user, I go to opac-tags. Both tags are marked not-approved. Somehow the $my_approved_tags array is empty. Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40915&action=edit Bug 6379: Fix if the reviewer is not the same patron get_approval_rows does a left join on tags_approval.approved_by = borrowers.borrowernumber This means it cannot return the approval tags for a given patron. Note that this patch could be time-consuming if there is a lot of tags in the DB. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #11)
I have added three tags with a normal user: Biblio 1: tag1 tag2 Biblio 2: tag1
I have approved tag1 in staff, did not touch tag2.
I see the tag1 in opac-detail. I can click on it and have two results. With the normal user, I go to opac-tags. Both tags are marked not-approved. Somehow the $my_approved_tags array is empty.
Failed QA
Good catch! This C4::Tags module is really a mess and I prefer not to touch it. The patch I propose should work but is not the best way to do. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39088|0 |1 is obsolete| | Attachment #40915|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43084&action=edit [PASSED QA] Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> works as described, no errors For the (approved) link to work I need to install YAML::XS Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43085&action=edit [PASSED QA] Bug 6379: Fix if the reviewer is not the same patron get_approval_rows does a left join on tags_approval.approved_by = borrowers.borrowernumber This means it cannot return the approval tags for a given patron. Note that this patch could be time-consuming if there is a lot of tags in the DB. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thknas Ojanahtn! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #16)
Patches pushed to master.
Thknas Ojanahtn!
You need some rest :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org