[Bug 8025] New: Patron attribute not selected if value is zero
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Priority: P5 - low Change sponsored?: --- Bug ID: 8025 CC: gmcharlt@gmail.com Assignee: adrien.saurat@biblibre.com Summary: Patron attribute not selected if value is zero Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Patrons Product: Koha TEST PLAN 1) If it doesn't exist, create an authorised value "YES_NO" with the following values : value 0 for "NO" value 1 for "YES" 2) Create a patron attribute using this authorised value. 3) Edit a patron and setup this new attribute for him. If you select YES, that's fine. If you select NO, it seems ok at first after validation, but if you come back on the editing page, the select box won't have its "selected" status on the "NO" option. Instead, the default empty line is selected. If you don't notice this and leave everything as it is, you'll reset your attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 9363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9363&action=edit proposed patch #1 The problem was spotted on patrons, but can be present on other pages too, as it comes from the GetAuthorisedValues function in Koha.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9363|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9385&action=edit [SIGNED-OFF] Bug 8025: corrects the return of a zero value for authorised values Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: If an authorised value equal 0, it can not be selected. This patch fix this problem. Mark as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org