[Bug 21785] New: Add column configuration to hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Bug ID: 21785 Summary: Add column configuration to hold ratios report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/reserveratios.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose to add column configuration to the hold ratios report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442 [Bug 21442] Switch two-column templates to Bootstrap grid: Circulation part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82046&action=edit Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- The patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pierre-Marc Thibault from comment #2)
The patch doesn't apply.
Did you apply the patch for Bug 21442 first? The patches apply okay for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- (In reply to Owen Leonard from comment #3)
(In reply to Pierre-Marc Thibault from comment #2)
The patch doesn't apply.
Did you apply the patch for Bug 21442 first? The patches apply okay for me.
Ah ok. I never dealt with a bug depending on another so I didn't for the 21442 entry. Sorry, you are probably right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82046|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 83298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83298&action=edit Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83298|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83570&action=edit Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Bug 21785 depends on bug 21442, which changed state. Bug 21442 Summary: Switch two-column templates to Bootstrap grid: Circulation part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org