[Bug 19722] New: Add a MaxItemsToDisplayForBatchMod preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Bug ID: 19722 Summary: Add a MaxItemsToDisplayForBatchMod preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The tool is setup to run in the background for actual modifications, but displaying the items beforehand can take too long and cause timeouts. We should add a syspref and use similar functionality from batch delete items where one can edit more than is viewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11490 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69426&action=edit Bug 19722 - Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #2 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Point 9 and 10 seem to be the same action with two different behaviors waited. Am I missing something ? Could you have a look and explain, please ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to jmbroust from comment #2)
Point 9 and 10 seem to be the same action with two different behaviors waited. Am I missing something ? Could you have a look and explain, please ?
Ah, they are testing two different preferences: MaxItemsTo Display ForBatchMod MaxItemsTo Process ForBatchMod If process is higher than display you should be able to process as many as process and they just won't show If process is lower and you try to edit more, you should be restricted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 abernaud <anne-claire.bernaudin@univ-rennes1.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |anne-claire.bernaudin@univ- | |rennes1.fr --- Comment #4 from abernaud <anne-claire.bernaudin@univ-rennes1.fr> --- Unable to test step 5 et 6 : not enough items in the sandbox At step 9 : the "job progress" bar stays at 0% and I get an error message : "Failed to submit form : error". Nothing happens after that. Other steps are OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to abernaud from comment #4)
Unable to test step 5 et 6 : not enough items in the sandbox
At step 9 : the "job progress" bar stays at 0% and I get an error message : "Failed to submit form : error". Nothing happens after that.
Other steps are OK.
You can add 1000+ items to a record in the edit items screen to easily get a large number Step 9 worked fine for me, can you check for JS errors and/or retest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com --- Comment #6 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi Nick, Yes it work, but I have problem with MaxItemsToProcessForBatchMod, it's not respected. For example, - I use file of 21 barcode - MaxItemsToProcessForBatchMod = 15 The batch item modification open correctly, not as without this patch, but it open all items in the file, not 15 as specify in MaxItemsToProcessForBatchMod. Thanks. Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69426|0 |1 is obsolete| | --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74682&action=edit Bug 19722 - Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Nick Clemens from comment #5)
(In reply to abernaud from comment #4)
At step 9 : the "job progress" bar stays at 0% and I get an error message : "Failed to submit form : error". Nothing happens after that.
Step 9 worked fine for me, can you check for JS errors and/or retest?
I had the same problem as abernaud when I tried to modify 1500 items with this parameters : allowed process = 2000 / display = 1000 I realize I was just impatient :) When I get this error, modification was very long and "Job process" not moving, but no more error when I tried again and waited to the end of modification, or when I tried with smaller quantity of items. Seems ok for me, thank you Nick ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Batch item deletion is broken, please double check. I always get "0 item(s) deleted." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77020&action=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The items are displayed at the end of the process (and so can lead to a timeout). Is it expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- You are correct, this should be updated to follow the system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74682|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87033&action=edit Bug 19722 - Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77020|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87034&action=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87035&action=edit Bug 19722: Don't show items at job completion if over pref To test: 1 - Set MaxItemsToDisplayForBatchMod to some number 2 - Modify less items than that 3 - Note they show a - Note if over 1000 they show in a simple display 4 - Modify more items 5 - Note they do not show and you see a note -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87033|0 |1 is obsolete| | Attachment #87034|0 |1 is obsolete| | Attachment #87035|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87077&action=edit Bug 19722: Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87078&action=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87079&action=edit Bug 19722: Don't show items at job completion if over pref To test: 1 - Set MaxItemsToDisplayForBatchMod to some number 2 - Modify less items than that 3 - Note they show a - Note if over 1000 they show in a simple display 4 - Modify more items 5 - Note they do not show and you see a note Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When batch editing large release notes| |amounts of items, | |displaying all of the info | |could lead to a timeout | |while waiting for page | |load. This enhancement adds | |the ability to define a | |MaxItemsToDisplayForBatchMo | |d system preference which | |will hide the list of | |individual items and allow | |libraries to edit larger | |batches without hitting a | |timeout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org