[Bug 35293] New: Regression: Bug 33390 (QA followup) patch overwrote the template changes to bug 25560
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Bug ID: 35293 Summary: Regression: Bug 33390 (QA followup) patch overwrote the template changes to bug 25560 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com After bug 25560, the description for UpdateNotForLoanStatusOnCheckin read:
- "This is a list of item types and value pairs.<br/><br/>" - "<strong>Examples:</strong><br/>" - "_ALL_:<br/>" - " -1: 0<br/><br/>" - "CR:<br/>" - " 1: 0<br/><br/>" - "When an item is checked in, if it's item type matches CR then when the value on the left (1) matches the items' not for loan value it will be updated to the value on the right.<br/><br/>The special term _ALL_ is used on the left side of the colon (:) to affect all item types, <strong>this does not override all other rules</strong><br/><br/>" - "Each item type needs to be defined on a separate line on the left side of the colon (:).<br/>Each pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space<br/><br/>"
After Bug 33390 was pushed, it now reads again as:
- This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan." - "Can be used for showing only the not for loan description. E.g. '-1: ONLYMESSAGE'." - Each pair of values should be on a separate line.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Bug 33390 (QA |Regression: Bug 33390 (QA |followup) patch overwrote |follow-up) patch overwrote |the template changes to bug |the template changes to bug |25560 |25560 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a rebase issue most likely. If you look at my follow-up, you can see it only changed a line break (for nicer translatability). https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158202 We still need to fix tho. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's not as easy as it sounds. The patch you refer to removed the mention of ONLYMESSAGE making it an undocumented feature. type: textarea syntax: text/x-yaml class: code - - This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value - - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan." - - "Can be used for showing only the not for loan description. E.g. '-1: ONLYMESSAGE'." - - Each pair of values should be on a separate line. + - "This is a list of item types and value pairs.<br/><br/>" + - "<strong>Examples:</strong><br/>" + - "_ALL_:<br/>" + - " -1: 0<br/><br/>" + - "CR:<br/>" + - " 1: 0<br/><br/>" + - "When an item is checked in, if it's item type matches CR then when the value on the left (1) matches the items' not for loan value it will be updated to the value on the right.<br/><br/>The special term _ALL_ is used on the left side of the colon (:) to affect all item types, <strong>this does not override all other rules</strong><br/><br/>" + - "Each item type needs to be defined on a separate line on the left side of the colon (:).<br/>Each pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space<br/><br/>" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are about to string freeze tomorrow and I am not sure I understand it all well enough yet :( Alex, could you confirm that ONLYMESSAGE should remain? It was added as a feature by bug 30407. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #3)
We are about to string freeze tomorrow and I am not sure I understand it all well enough yet :(
Alex, could you confirm that ONLYMESSAGE should remain?
It was added as a feature by bug 30407.
Hi Katrin, My apologies for my slow reply. I've checked and yes can confirm ONLYMESSAGE should remain. The way I confirmed this for sure was running the t/db_dependent/Circulation/issue.t unit test file, which passes both for my changes in bug 25560 and the ONLYMESSAGE changes in bug 30407. Please let me know if there is anything I can do to help, and apologies again for my delay. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If you have a moment to write the merged/combined system preference description I could sign off on it in the morning. But we are already in string freeze. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #5)
If you have a moment to write the merged/combined system preference description I could sign off on it in the morning. But we are already in string freeze.
Hi Katrin, Thanks for that. Yes sure thing. Writing that now, attaching shortly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158850&action=edit Bug 35293: Add ONLYMESSAGE back into UpdateNotForLoanStatusOnCheckin syspref description Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158851&action=edit Bug 35293: Re-implement bug 30407 functionality To test: 1. Set items notforloan status as -1 (or create new one) 2. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 3. Check item out for patron. 4. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status HAS changed. 5. Apply patch and update database if needed 6. Set items notforloan status as -1 (or create new one) 7. Check item out for patron. 8. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status HAS NOT changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin, I have attached a patch for combining the system preference description. I found that although the issue.t unit test passed successfully on master, the behaviour for the user in the bug 30407 test plan does not actually happen on master. i.e. when you check in an item it's notforloan status does change when it shouldn't. So I have attached a second patch which re-implements the behaviour from bug 30407 - not sure why that was lost on master. Please feel free to test or handle these patches as you see fit. I hope they are of some help. Thanks Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |anneli.osterman@koha-suomi. | |fi --- Comment #10 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- We tested this but could not reproduce the problem. 1. Notforloan item cannot be checked out with the provided systempreferences. 2. If you check in a not for loan item without checkin in it first, Koha only tells that the item was not onloan. 3. If you allow checkin out of notforloan items and then do the check out and check in, Koha does not tell anything about the notforloan status. Even when ONLYMESSAGE is configured to UpdateNotForLoanStatusOnCheckin. 4. The notforloan status did not dissapear on check in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158851|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 160360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160360&action=edit Bug 35293: Re-implement bug 30407 functionality To test: 1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride system preference to 'Allow' 2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the formatting and indentation is important to keep): BK: -1: ONLYMESSAGE 3. Check a book item out for patron. 4. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS changed. 5. Apply patch and update database if needed 6. Set book items notforloan status as -1 (or create new one) 7. Check book item out for patron. 8. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS NOT changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Anneli Österman from comment #10)
We tested this but could not reproduce the problem.
1. Notforloan item cannot be checked out with the provided systempreferences. 2. If you check in a not for loan item without checkin in it first, Koha only tells that the item was not onloan. 3. If you allow checkin out of notforloan items and then do the check out and check in, Koha does not tell anything about the notforloan status. Even when ONLYMESSAGE is configured to UpdateNotForLoanStatusOnCheckin. 4. The notforloan status did not dissapear on check in.
Hi Anneli, Happy holidays! Thank you for testing. I've tweaked the test plan - to include adding the item type into the UpdateNotForLoanStatusOnCheckin syspref then issuing and returning an item of that type. Would you mind please re-testing? Thanks very much, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158850|0 |1 is obsolete| | --- Comment #13 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 160361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361&action=edit Bug 35293: Add ONLYMESSAGE back into UpdateNotForLoanStatusOnCheckin syspref description Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160360|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 160362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160362&action=edit Bug 35293: Re-implement bug 30407 functionality To test: 1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride system preference to 'Allow' 2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the formatting and indentation is important to keep): BK: -1: ONLYMESSAGE 3. Check a book item out for patron. 4. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS changed. 5. Apply patch and update database if needed 6. Set book items notforloan status as -1 (or create new one) 7. Check book item out for patron. 8. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS NOT changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160361|0 |1 is obsolete| | Attachment #160362|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160553&action=edit Bug 35293: Add ONLYMESSAGE back into UpdateNotForLoanStatusOnCheckin syspref description Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160554&action=edit Bug 35293: Re-implement bug 30407 functionality To test: 1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride system preference to 'Allow' 2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the formatting and indentation is important to keep): BK: -1: ONLYMESSAGE 3. Check a book item out for patron. 4. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS changed. 5. Apply patch and update database if needed 6. Set book items notforloan status as -1 (or create new one) 7. Check book item out for patron. 8. Check book item in. => Description of notforloan status should be displayed under 'Check in message'. => Confirm notforloan status HAS NOT changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160555&action=edit Bug 35293: (follow-up) Handle all rules as well Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160556&action=edit Bug 35293: Unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 35692 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30407, 25560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 [Bug 33431] Make code use C4::Context->yaml_preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Bug 35293 depends on bug 25560, which changed state. Bug 25560 Summary: Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org