[Bug 23953] New: Cancelling hold does not work if checkout not completed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Bug ID: 23953 Summary: Cancelling hold does not work if checkout not completed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: 1. Place a hold on item A for patron A 2. Check out item A to patron B 3. See the prompt to confirm the checkout because the hold for patron A exists. Check the 'cancel hold' checkbox and click the 'No, don't check out' button 4. Notice the hold for patron A is NOT cancelled <-- bug 5. Attempt to check out item to patron B again 6. This time, check the 'cancel hold' checkbox but click the 'Yes, check out' button 7. Notice that item A is successfully checked out to patron B and the hold for patron A has been cancelled. Therefore, the 'cancel hold' checkbox does not work if the checkout is not completed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like a long standing issue and I did not find a duplicated bug report, that's weird. At first glance I would say the checkbox is only taken into consideration for "Yes, check out" https://snipboard.io/jEXNBP.jpg Not sure how we could make it clear on the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Yes it is a weird one. I think given that the option is a checkbox, it does imply that it's a separate action to the button, and you should be able to cancel a hold while clicking any button. In this case I think we just need to ensure that the cancel hold checkbox is considered if any of the buttons is clicked. Otherwise, the checkbox should be removed and the cancel hold action should be a second screen confirmation, after choosing "Yes, check out". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Something like that? https://snipboard.io/UXsqMB.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
Something like that? https://snipboard.io/UXsqMB.jpg
Actually it's more than 2 options as there is also another checkbox for "Revert waiting status", if the hold is waiting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #4)
(In reply to Jonathan Druart from comment #3)
Something like that? https://snipboard.io/UXsqMB.jpg
Actually it's more than 2 options as there is also another checkbox for "Revert waiting status", if the hold is waiting.
That could work! Would just also need the "Yes, check out and revert waiting status" option too. And to standardise the style of the other buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17798 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org