[Bug 16366] New: Remove obsolete "border" attribute from <img> tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Bug ID: 16366 Summary: Remove obsolete "border" attribute from <img> tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are many instances in the staff client templates where a border attribute is applied to an <img> tag. The border attribute is obsolete and unnecessary and can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50810&action=edit Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Testing... - In the patron sidebar menu, if patron images are enabled. OK - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). OK (compared code in diff) - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? OK (compared code in diff) - On the advanced search page, itemtype/collection/shelving location images should look correct. OK - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. OK - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50810|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 50812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50812&action=edit Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50812|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50833&action=edit [PASSED QA] Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16366 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org