[Bug 31651] New: Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Bug ID: 31651 Summary: Log message incorrect in Auth_with_shibboleth.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org There's a bad copy/paste of a log message in Auth_with_shibboleth.pm. The second occurance of `There are several users with $config->{matchpoint} of $match, matchpoints must be unique` should really read something like `No users with $config->{matchpoint} of $match found and autocreate is disabled` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Assignee|koha-bugs@lists.koha-commun |jacob.omara@ptfs-europe.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #1 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 144312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144312&action=edit BUG 31651: Replaced duplicate error message The duplicated error message on ln119 has now been replaced for clarity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #2 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Test plan to follow.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've set to NSO as the patch is complete.. though we should probably add a Unit test to be thorough. Where we're struggling is how to write a test plan which could use the new --sso functionality of ktd to setup a shibboleth IdP such that this trivial patch can be proven. CCing David whose much more familiar with KeyCloak.. I think we could do with getting a few little mini guides on how to set these things up for quick tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #3)
CCing David whose much more familiar with KeyCloak.. I think we could do with getting a few little mini guides on how to set these things up for quick tests.
Sounds like a plan. I'll put it on my TODO list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #3)
CCing David whose much more familiar with KeyCloak.. I think we could do with getting a few little mini guides on how to set these things up for quick tests.
I have a few tasks I want to get done this week, so I think I'll try to set up those mini guides next week before going on holidays... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Was going to SO here but are we waiting for unit tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #3)
CCing David whose much more familiar with KeyCloak.. I think we could do with getting a few little mini guides on how to set these things up for quick tests.
I've created the wiki page https://wiki.koha-community.org/wiki/Testing_SSO I haven't filled it in yet, but I'll see if I can get something up soon... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
I've created the wiki page https://wiki.koha-community.org/wiki/Testing_SSO
I haven't filled it in yet, but I'll see if I can get something up soon...
Apparently I'm not good at leaving things be... so I went ahead and created the guides. The formatting needs work but I've tested both OpenID Connect and SAML with Keycloak and both worked. The SAML guide took a few iterations, so if something doesn't work, it's probably because I forgot to make update it. But I think it should be right. Note that Koha forces HTTPS for SAML, which is good in theory, but not so good for testing. However, you can manually bypass this by updating the URL yourself to be HTTP only. -- In the near future, we could probably set up koha-testing-docker to have more of this setup out of the box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #3)
I've set to NSO as the patch is complete.. though we should probably add a Unit test to be thorough.
Failing this based on Martin's comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #3)
I've set to NSO as the patch is complete.. though we should probably add a Unit test to be thorough.
Is this realistic without rewriting Auth_with_shibboleth.pm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this is a trivial fix really.. we should let it through without the unit test and return to testing at a later date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. there's already an Auth_with_shibboleth.t test where I mocked an aweful lot.. we may be able to add tests there actually.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #12)
Hmm.. there's already an Auth_with_shibboleth.t test where I mocked an aweful lot.. we may be able to add tests there actually..
While a test would be great, this looks mostly like a string change to me. I couldn't test, but all the same variables are used and the code comment is pretty clear too. I'll sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152600&action=edit Bug 31651: Replaced duplicate error message The duplicated error message on ln119 has now been replaced for clarity. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144312|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 144312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144312 BUG 31651: Replaced duplicate error message This actually had no sign-off yet, so mine is a SO. Also fixed commit message: BUG.. should be Bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152600|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152620&action=edit Bug 31651: Replaced duplicate error message The duplicated error message on ln119 has now been replaced for clarity. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152865&action=edit Bug 31651: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org