[Bug 23289] New: Label Template - Creation not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Bug ID: 23289 Summary: Label Template - Creation not working Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: user@papsdorf.de QA Contact: testopia@bugs.koha-community.org Hi, Create a "Label Template" and save. (any configuration ....) There is no error message. But it shows a message indicating that "there is no template". The error log shows the following: label-edit-template.pl: Database returned the following error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, page_height, label_width, label_height) VALUES ('0','Labels','0','0','0','' at line 1 at /usr/share/koha/lib/C4/Creators/Template.pm line 201.: /usr/share/koha/intranet/cgi-bin/labels/label-edit-template.pl Koha version: 19.0501000 MariaDB: 10.3.15 Could you verify it, please. Thanks in advance Andre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Andre <user@papsdorf.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker CC| |user@papsdorf.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andre, it's working for me on master. Did you change/add anything in the form? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 --- Comment #2 from Andre <user@papsdorf.de> --- Hi Katrin, I changed nothing. It is just a new installation on Debian 10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is it possible you are running MariaDB in strict mode? It should be off by default, but depending on how you installed or changed it could be a reason (https://wiki.koha-community.org/wiki/SQL_modes) Running a bit out of ideas, it might be worth bringing this up on the koha-devel mailing list as more people will read it there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 --- Comment #4 from Andre <user@papsdorf.de> --- You are right. MariaDB seems to be running in strict mode, but this is as default since 10.2.4 https://mariadb.com/kb/en/library/sql-mode/#strict-mode After a standard Debian 10 installation (no changes on default) and following these sites: https://wiki.koha-community.org/wiki/Preparing_your_system https://wiki.koha-community.org/wiki/Koha_on_Debian I installed MariaDB as descriped under "Install the Database" The error is only for the "lable template", the printer profile and layouts are working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|blocker |major --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Dropping the severity a bit, still an issue though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Label Template - Creation |Label Template - Creation |not working |not working with SQL strict | |mode enabled CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- I'm not sure that the SQL mode is the problem per se; rather, as of 10.2.4, "rows" is now a reserved word in MariaDB and cannot be used as a identifier (e.g., a column name) without quoting it. Using backticks to quote the word in the insert statement would make it work, but of course that violates the SQL6 guideline (though given commit fd30cac85, perhaps that guideline isn't being enforced?). It doesn't look like ANSI_QUOTES or ANSI are being set either. Renaming label_templates.rows column is another option, of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17258 | Summary|Label Template - Creation |Label Template - Creation |not working with SQL strict |not working (MariaDB >= |mode enabled |10.2.4) Assignee|cnighswonger@foundations.ed |jonathan.druart@bugs.koha-c |u |ommunity.org Version|19.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92520&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92520|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92528&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92528|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 92613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92613&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23960 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 23960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org