https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #283 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #282)

The difference with the past patches is that we don't get the warnings/restrictions in the UI *before* placing the hold. We only get the warnings about failures *after* trying to place the hold.

I think warning *before* the hold is actually a separate feature.

I actually don't know if there is a practical bug-free way of doing it *before*, since each individual item can have different rules. There's a complex interplay of rules. For instance, item A could have 1 "Holds per record", while item B could have 10 "Holds per record". Trying to pre-emptively calculate holdability on selected holds rather than placed holds... is tough to do without potential for errors. One could argue that it's unlikely a bib record would have items of different types, but I see it all the time. That said, only warning *after* trying to place the holds isn't great, because it might not be obvious which holds were placed and which weren't placed. But we can't do much about that while our hold placing scripts use redirects. Replacing those redirects with API calls would work better, because the user would be able to see immediately which holds were placed and which weren't. (But that also involves messing around with the DOM in unfun ways - unless we use Vue.) -- You are receiving this mail because: You are watching all bug changes.