[Bug 14895] New: We shouldn't be able to edit already added serials' items from serial receive/edit page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Bug ID: 14895 Summary: We shouldn't be able to edit already added serials' items from serial receive/edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: j.kylmala@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When you receive some serials you go to the serials/serials-edit.pl page. You change there the status to 'Arrived' and add a new item (if it has been chosen so in the subscription creation step). Now if after that someone goes and changes the status to, for example, 'Expected' then the system automatically overrides the item's info which is already in the system. This happens because the serial-edit.pl don't retrieve any information from the items which are already in the system. Well, I guess nobody will change an arrived item to expected usually, only in the cases when it has been a misclick or something. So the real problem is that if you just go to the serials-edit.pl page and don't change anything, and click save, the existing item will have some of its info deleted (barcode as one example). I have a patch for this problem (will add soon here). Instead of retrieving the already added items' data I choosed to disable the "ability" to change the already added items' info from serials-edit.pl (one can change item information from cataloguing -> something, if needed). I guess my explanation is not so clear, so I will provide you the steps how to reproduce this bug: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42867&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42867|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42868&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Notice that this patch is done for 3.16. It might not apply without manual merging to the upstream. Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #3 from Joonas Kylmälä <j.kylmala@gmail.com> --- Looks like the patch applied correctly also to the latest master! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42868|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42869&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi Assignee|koha-bugs@lists.koha-commun |j.kylmala@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42869|0 |1 is obsolete| | --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 44937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44937&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears similar to bug 15030 - which I think tries to fix the behaviour. Liz, could you maybe take a look at the other bug too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Or Joonas? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15030 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala@gmail.com |koha-bugs@lists.koha-commun | |ity.org --- Comment #8 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Katrin Fischer from comment #7)
Or Joonas?
I'm not working on this bug anymore, so someone else feel free to assign this to him- or herself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44937|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45055&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45056&action=edit Bug 14895 [QA Followup] - Fix indentation for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Considering bug 15030 is in active development, we should probably wait to see if that one takes care of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org