[Bug 27442] New: Circulation Module Report "Overdues" does not accurately show overdues by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Bug ID: 27442 Summary: Circulation Module Report "Overdues" does not accurately show overdues by date Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I believe the SQL is wrong in the hardcoded report "Overdue" under the Circulation Module. When a due date range is added when running the report, it is not showing the items that are overdue for a particular date, a library will need to run a range of 2 days to find out the day's overdue. Steps to Recreate: 1. Run Overdue report 2. Use the filter on the left to enter the date due to range of 10/12- 10/12. 3. No results are found with the actual date due to 10/12 4 Run the same report using the filter set at 10/12 - 10/13. 5 Koha will provide items that are due on 10/12. The SQL is looking at date_due rather than date(date_due) which is not giving accurate results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've been unable to recreate this in my testing docker on master, 20.05, or 19.11. Here's what I tried: To test: 1 - check an item out with a due date of yesterday, 23:59:59 2 - go to overdue.pl, observe that the defauly search for all overdues includes your checkout 3 - perform a new search on overdue.pl, entering yesterday's date for both the FROM and TO limits on Date due 4 - your checkout still shows in the new search Per your description, I'd expect to not see the checkout in step 4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kelly, could you please retest? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- Katrin, This can be closed! The due dates of these items were updated incorrectly and therefore not getting captured! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED Summary|Circulation Module Report |Circulation Module Report |"Overdues" does not |"Overdues" assumes time of |accurately show overdues by |23:59:00 on upper bound of |date |search --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- On second thought, I think there is still a bug here. When one sets a date range on this report, Koha appends a time onto the later date in order to account for the fact that our date_due values include a time. However, the time it appends is 23:59:00. That's mostly ok, since Koha generally uses 23:59:00 as its end-of-day date_due time. However, if events conspire such that one ends up with items due between 23:59:01 and 23:59:59, those items will be left out of the report. We should just make Koha append 23:59:59 instead. If someone wants to get fancy in a later bug, we could also add a time-picker to the interface and let one limit the search by time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 115351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115351&action=edit Bug 27442: Assume 23:59:59 for date due end date To test: 1 - have a checkout due yesterday at 23:59:59 2 - go to overdue.pl, search with yesterday's date in the From and To dates 3 - confirm your checkout is not listed 4 - change your To date to today 5 - confirm your check is listed 6 - apply patch, restart service 7 - repeat step 2 8 - your checkout is there! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115351|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119801&action=edit Bug 27442: Assume 23:59:59 for date due end date To test: 1 - have a checkout due yesterday at 23:59:59 2 - go to overdue.pl, search with yesterday's date in the From and To dates 3 - confirm your checkout is not listed 4 - change your To date to today 5 - confirm your check is listed 6 - apply patch, restart service 7 - repeat step 2 8 - your checkout is there! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Circulation Module Report |Overdues report uses |"Overdues" assumes time of |23:59:00 on To date filter |23:59:00 on upper bound of | |search | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Really small change, going to set this directly to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How do you checkout an item with a due date containing 59 in the second part? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8)
How do you checkout an item with a due date containing 59 in the second part?
Hm, I thought you could not with the widget, but manually enter it - I was mistaken. I wonder if a process in Koha would generate such cases or if it was a migration issue initially? I think it would not hurt here as we are using a field that stores seconds as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We have other places in the code where we ->set_minute(59) and does not care about the seconds. I don't think this patch should be pushed as it without knowing why there are possibly checkouts created with 59 in the seconds part. Also, one place in C4::Circ is doing: 3704 $hardduedate->truncate( to => 'minute' ); 3705 $hardduedate->set_hour(23); 3706 $hardduedate->set_minute(59); Kelly, Andrew, can you give us more info please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrewfh@dubcolib.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Kelly, Andrew, can you give us more info please?
Ping! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #12 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- In all honesty, at this point I remember that we filed this because we ran into a Koha system that had due dates with 23:59:59 due dates, but I can no longer recall what that system was or how those checkouts were created. It's possible they were migrated in that way and it's not actually possible to set a due date with seconds on a checkout performed in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am trying to see how we could resolve it - would closing it and fixing the data if you run into it again be an option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #14 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Works for me! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org