[Bug 17829] New: Move GetMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug ID: 17829 Summary: Move GetMember to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See https://github.com/joubu/Koha/commits/bug_17829 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased against master. Asking for a signoff now. Test plan: - send notices - place holds - play with acquisition: create basket, orders, receive them, transfer them - play with circulation: checkout/in - play with patrons: add a discharge, delete a patron, edit password and permissions, create invoices and pay them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17737, 17738, 17680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have worked for several days on bug 18403, on top of these patches, and did not find any errors. I am quite confident with these patches, even if the changes are important. Please do not let them wait too long. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16282 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17737, which changed state. Bug 17737 Summary: Move GetReservesFromItemnumber to Koha::Item->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not sure how signoff works on a github branch.. but I've tested thoroughly and am happy to signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Remote branch has been rebased.
It doesn't apply due to updatedatabase.pl conflicts... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #8)
(In reply to Jonathan Druart from comment #7)
Remote branch has been rebased.
It doesn't apply due to updatedatabase.pl conflicts...
I'm sorry, the updatedatabase.pl merge problem was not the problem (easy fix). The problem was in Circulation.pm: diff --cc C4/Circulation.pm index 7e65a80,789a85f..0000000 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@@ -1903,16 -1904,15 +1904,23 @@@ sub AddReturn } if ($borrowernumber) { ++<<<<<<< HEAD ++======= + if ( ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) || $return_date ) { + _CalculateAndUpdateFine( { issue => $issue, item => $item, borrower => $borrower, return_date => $return_date } ); + } + ++>>>>>>> dadae20... Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls eval { - MarkIssueReturned( $borrowernumber, $item->{'itemnumber'}, + my $issue_id = MarkIssueReturned( $borrowernumber, $item->{'itemnumber'}, $circControlBranch, $return_date, $borrower->{'privacy'} ); + $issue->{issue_id} = $issue_id; }; - if ( $@ ) { + unless ( $@ ) { + if ( ( C4::Context->preference('CalculateFinesOnReturn') && $issue->{'overdue'} ) || $return_date ) { + _CalculateAndUpdateFine( { issue => $issue, item => $item, borrower => $borrower, return_date => $return_date } ); + } + } else { $messages->{'Wrongbranch'} = { Wrongbranch => $branch, Rightbranch => $message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64872&action=edit Bug 17829: Move GetMember to Koha::Patron GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64873&action=edit Bug 17829: followup for request.pl This script is really ugly and need to be rewritten completely to separate the different action. $patron is not always defined, we need to take it into account. Note that this patch is mainly indentation changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17738, which changed state. Bug 17738 Summary: Move GetReservesFromBorrowernumber to Koha::Patron->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17554, which changed state. Bug 17554 Summary: Move GetBorrowersWithEmail to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64872|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64971&action=edit Bug 17829: Move GetMember to Koha::Patron GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64873|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64972&action=edit Bug 17829: followup for request.pl This script is really ugly and need to be rewritten completely to separate the different action. $patron is not always defined, we need to take it into account. Note that this patch is mainly indentation changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64973&action=edit Bug 17829: (followup) Fix small rebasing errors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Excellent, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64976&action=edit Bug 17829: Update CanUserManageBasket to fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65002&action=edit Bug 17829: (follow-up) Move GetMember to Koha::Patron Prevent crash at the opac when no user is logged in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14385 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18938 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18938 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18938 [Bug 18938] opac/svc/patron_notes and opac/opac-issue-note.pl use GetMember -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17680, which changed state. Bug 17680 Summary: C4::Circulation - Replace GetItemIssue with Koha::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65213&action=edit Bug 17829: Fix import patron Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/tools/import_borrowers.pl line 230, <$fh> line 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch has been pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65286&action=edit Bug 17829: Execute rollingloans tests in a transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch has been pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #26 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Found that the initial patch breaks searching by name in staff client. Go to patron page enter name in search box (Enter patron card number or partial name) and search - nothing is ever returned. Resetting the system to the status before the initial patch restores ability to search by name. First impression looking at the code, GetMember was handling doing a name search, almost as a side effect of the more specific 'number' searches and we've lost that functionality. This may have implications elsewhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Colin, I do not recreate the problem you describe. Could you give me more details please? Are you referring to the call from members/member.pl or another one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17680, which changed state. Bug 17680 Summary: C4::Circulation - Replace GetItemIssue with Koha::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #28 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #27)
Hi Colin, I do not recreate the problem you describe. Could you give me more details please? Are you referring to the call from members/member.pl or another one?
I've traced it through its when svc/members/search is called ultimately it gets logged in the error log search: Undefined subroutine &C4::Members::Attributes::SearchIdMatchingAttribute called at /home/cc/kohaclone/C4/Utils/DataTables/Members.pm line 127.: /home/cc/kohaclone/svc/members/search, referer: http://admin/cgi-bin/koha/members/member.pl at line 127 of C4::Utils/DataTables/Members.pm we have my $matching_borrowernumbers = C4::Members::Attributes::SearchIdMatchingAttribute($searchmember); which needs replacing with an equivalent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #29 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Bug 17829 depends on bug 17680, which changed state. Bug 17680 Summary: C4::Circulation - Replace GetItemIssue with Koha::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19048 [Bug 19048] Self checkout: Internal server error in sco-main.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #30 from Marc Véron <veron@veron.ch> --- Created attachment 65549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65549&action=edit Bug 19048: (bug 17829 follow-up) Fix regression in self checkout $patronid is not necessarily set or does not match a valid cardnumber. These cases must be taken into account to avoid the script to crash and raise the following error: Can't call method "unblessed" on an undefined value at (...)/koha/opac/sco/sco-main.pl line 117 Test plan: Hit sco/sco-main.pl and confirm that the error is gone with this patch applied Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #65549|0 |1 is obsolete| | --- Comment #31 from Marc Véron <veron@veron.ch> --- Comment on attachment 65549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65549 Bug 19048: (bug 17829 follow-up) Fix regression in self checkout Sorry, wrong Bug number... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65778&action=edit Bug 17829: (follow-up) Move GetMember to Koha::Patron - routing-lists.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #32)
Created attachment 65778 [details] [review] Bug 17829: (follow-up) Move GetMember to Koha::Patron - routing-lists.pl
Patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66360&action=edit Bug 17829: (follow-up) Fix import patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #34)
Created attachment 66360 [details] [review] Bug 17829: (follow-up) Fix import patron
Patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080 [Bug 19080] Handle non existing patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65002|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68634&action=edit Bug 17829: (follow-up) Move GetMember to Koha::Patron Do not call method on $patron if there is no other reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #36)
Created attachment 68634 [details] [review] Bug 17829: (follow-up) Move GetMember to Koha::Patron
Do not call method on $patron if there is no other reserves
Patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 [Bug 19808] Reviews from deleted patrons make few scripts to explode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 [Bug 20003] Result summary of remaining checkouts items not displaying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 [Bug 20303] Receive order fails if no "authorised_by" value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 [Bug 20348] SIP2 patron identification fails to use userid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 [Bug 21019] Borrower address not shown on reserve pop-up on returns.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org