[Bug 11809] New: Bootstrap should not show Clear date -link if the date is required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Bug ID: 11809 Summary: Bootstrap should not show Clear date -link if the date is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org In OPAC, when patron changes his personal information, the page shows a "Clear date" -link after the Date of Birth -input, even when DoB is set to required field. That link should not be shown if DoB is required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bootstrap should not show |OPAC patron details form |Clear date -link if the |shouldn't show 'Clear date' |date is required |if field is required -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25544&action=edit Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25558&action=edit [Signed-off] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. I tested with prog and bootstrap themes, adding/removing field 'dateofbirth' in sys pref PatronSelfRegistrationBorrowerMandatoryField. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25544|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25563&action=edit [PASSED QA] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. I tested with prog and bootstrap themes, adding/removing field 'dateofbirth' in sys pref PatronSelfRegistrationBorrowerMandatoryField. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org