[Bug 13231] New: ISBD/AACR2 punctuation causes double facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Bug ID: 13231 Summary: ISBD/AACR2 punctuation causes double facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org Created attachment 33454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33454&action=edit Naively remove ISBD punctuation from facets Using MARC21, assume the following in one biblio: 100 1 $aFoo, $ewriter. And this in another biblio: 100 1 $aFoo. This produces double facets, one of "Foo," and another for "Foo." - It should just use one facet, "Foo" Attached is a quick hack to achieve this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the former facet code removed the punctuation at the end and did some other tricks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- I could reproduce the double facets following the test plan. Howver, the patch did not apply on current master, I got: Apply? [(y)es, (n)o, (i)nteractive] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in <module> do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1312, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marc Véron from comment #2)
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>
That looks like a networking issue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #4 from Marc Véron <veron@veron.ch> --- I tried with other bugs / patches, no problem to apply, only with this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the patch file is missing a few lines at the top - might need to be redone. I have the same error as Marc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33454|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39704&action=edit [SIGNED-OFF] Bug 13231: ISBD/AACR2 punctuation causes double facets (Reworked patch, original from paxed was a diff file) Naively remove ISBD punctuation from facets Using MARC21, assume the following in one biblio: 100 1 $aFoo, $ewriter. And this in another biblio: 100 1 $aFoo. This produces double facets, one of "Foo," and another for "Foo." - It should just use one facet, "Foo" Attached is a quick hack to achieve this. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test: 2 records modified as proposed, search by author gives 2 facets With patch only one No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, 2 things here: I think the described case can only happen when not using authorities as there seems no way to include ISBD punctuation at the end when you do. The other thing is more serious: With displayFacetCount turned ON, the number of facets shown with the patch is wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #9 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Katrin Fischer from comment #8)
Hm, 2 things here: I think the described case can only happen when not using authorities as there seems no way to include ISBD punctuation at the end when you do.
No way to include ISBD punctuation when adding/changing authorities? What do you mean? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In testing I found it impossible to add . or similar to a heading linked to an authority record - but I just added that note here for documentation. So it would be easier for others to test. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org