[Bug 8061] New: Koha's templates do not cope well with right-to-left languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Priority: P5 - low Change sponsored?: --- Bug ID: 8061 Assignee: frederic@tamil.fr Summary: Koha's templates do not cope well with right-to-left languages Severity: major Classification: Unclassified OS: All Reporter: ruth@bywatersolutions.com Hardware: All Status: NEW Version: unspecified Component: I18N/L10N Product: Koha The current codes add "dir='rtl'" to the template's <HTML> tag if the languages is defined as right-to-left, in the language_script_bidi table, which is a good start, but the templates contain many floats and text-aligns in the CSS that make actual layout of the pages thoroughly nonsensical for RTL readers. Separate patches for OPAC and Staff, coming soon! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic@tamil.fr |ruth@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #1 from D Ruth Bavousett <ruth@bywatersolutions.com> --- Created attachment 9470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9470&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I have noticed a few issues with this patch. The layout is wrong for the opac-privacy.pl page, as well as in the language chooser at the bottom: http://screencast.com/t/OQumB19gm I don't like the layout for the opac-messaging.pl, though if native speakers find it acceptable, I am prepared to sign off on it as is (notice the table on the right and the heading on the left): http://screencast.com/t/8Yg94tzAWy There's a similar table layout problem on the suggestions page. On the details page there are a two problems that jump out. 1) The items table is right-justified but the tabs are left-justified. 2) The search pager buttons are backwards. Next is on the right, and previous is on the left, but the arrows are pointing left and right, respectively: http://screencast.com/t/g0G4Ly9l On the advanced search page, the alignment for the search boxes at the top is off: http://www.screencast.com/t/qpGlVCukVpcx This definitely represents a huge improvement, though. Well done! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #3 from D Ruth Bavousett <ruth@bywatersolutions.com> --- Created attachment 9579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9579&action=edit Proposed patch (Staff) This is a first-draft. I expect to find lots of tweaking that needs to be done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Ruth Unfortunately the first patch no longer applies Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 8061: RTL CSS overrides (OPAC) The second one conflicts too Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #5 from Karam Qubsi <karamqubsi@gmail.com> --- I fell like there is some problems facing us to apply rtl direction by default when using on of the rtl languages when I'm trying to set the css files i found that there is some styles cannot be changed from css files only so this is a problem for example : /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/includes/opac-bottom.inc you can see : [% IF ( languages_loop && opaclanguagesdisplay ) %] [% UNLESS ( one_language_enabled ) %] <div id="changelanguage" class="ft"> <div class="lang" style="float:left;padding: 0.1em 0;"><strong>Languages: </strong></div> Floats and this will make the general css files not effect on this file I fix this by hand but I think this must be not here and all the styles must be just in the css files to make it easier in changing the direction to rtl i don't have experience in patching but I hope if some one can guide me how to test your patch I have rtl css files make koha about 80% good in rtl but need some debugging I will attach it here . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #6 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 13087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13087&action=edit RTL css files 80% good I think this files is good to start with and we can enhance them with time I wish you try them thanks karam . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Patch doesn't apply |In Discussion Change sponsored?|--- |Seeking developer --- Comment #7 from Karam Qubsi <karamqubsi@gmail.com> --- I wish this will be solved in the next koha release 3.12 . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Karam, the patches attached here currently no longer apply. We need someone to take a look at them and rebase them on current master. Maybe it coudl be done in smaller steps/patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13087|0 |1 is obsolete| | --- Comment #9 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17178&action=edit Right to left for staff Client Hi all, I think this patch is good for th rtl langs. and based on what D.Ruth send before , I added some edits as a right to left reader. Tested on Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Regards . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Karam, thx for working on this. :) Just a few short notes to move this in the right direction (into Koha): - Is your new patch for master or 3.8? - Is it based on Ruth's patch? In this case it would be better if you could provide a follow up with your changes, so that you both can get proper credit for the work that has gone into this. If you need help with git, I am sure we can work something out. If we could get a patch ready for 3.12 in the next few weeks, that would be quite nice! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Karam told me that his patch is based on master - so this is good. Not sure if we should just handle it as a rebase and Karam's work as a sign-off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #12 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17206&action=edit (staff) D.Ruth Patch to fit master I do the changes manually and create this patch that includes the edits from D. Ruth . Karam . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17178|0 |1 is obsolete| | --- Comment #13 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17207&action=edit (Staff) Enhancement to D.Ruth Patch This second patch includes the modifications that I made . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #14 from Karam Qubsi <karamqubsi@gmail.com> --- Hi Katrin I hop this will solve the problem ^_^ . Best regards Karam. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Karam++ :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #16 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17215&action=edit (Opac-Prog) D.Ruth patch to fit master I do the changes manualy and create this patch from D.Ruth work . on Opac prog . it is very useful I do my changes in the next patch ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #17 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17216&action=edit Follw up (Opac-Prog) enhancment on D.Ruth work .. This will make the opac very acceptable by the rtl users :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|unspecified |master Change sponsored?|Seeking developer |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17206|0 |1 is obsolete| | Attachment #17207|0 |1 is obsolete| | Attachment #17215|0 |1 is obsolete| | Attachment #17216|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17231&action=edit [SIGNED-OFF] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17232&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before , I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (b -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17231|0 |1 is obsolete| | Attachment #17232|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17233&action=edit [SIGNED-OFF] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17234&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17235&action=edit [SIGNED-OFF] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17236&action=edit Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches are now waiting for sign offs on the follow-ups Karam did. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17233|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17237&action=edit Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17234|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17238&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17235|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17239&action=edit Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17238|0 |1 is obsolete| | --- Comment #28 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17240&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17237|0 |1 is obsolete| | --- Comment #29 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17241&action=edit Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17239|0 |1 is obsolete| | --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17242&action=edit Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17240|0 |1 is obsolete| | --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17243&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17243|0 |1 is obsolete| | --- Comment #32 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17244&action=edit Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17236|0 |1 is obsolete| | --- Comment #33 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17245&action=edit Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17241|0 |1 is obsolete| | Attachment #17242|0 |1 is obsolete| | Attachment #17244|0 |1 is obsolete| | Attachment #17245|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17246&action=edit [PASSED QA] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Arabic po files from 3.8. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17247&action=edit [PASSED QA] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17248&action=edit [PASSED QA] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17249&action=edit [PASSED QA] Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with po files for Arabic from 3.8. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|druthb@gmail.com |karamqubsi@gmail.com QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #39 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 17286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17286&action=edit OPAC-CCSR-Right-to-left-css Hi :) This patch will add css file for the Opac cssr link this css file in the doc-head-close.inc and add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one . The test plan is the same for the oldest patches for opac prog and intranet ... I think now all Koha interfaces support rtl languages thanks for you All . Karam. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 --- Comment #40 from Karam Qubsi <karamqubsi@gmail.com> --- I reported a new bug for the ccsr so the : OPAC-CCSR-Right-to-left-css (11.00 KB, patch) is obsoleted the new bug . http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10017 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org