https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36934 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36933 |26176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26176 [Bug 26176] AutoLocation is badly named -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36934 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think I see the issue - we aren't getting a sessionID after the failure: 1224 if ( $ip !~ /^$domain/ ) { 1225 $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( 1226 -name => 'CGISESSID', 1227 -value => '', 1228 -HttpOnly => 1, 1229 -secure => ( C4::Context->https_enabled() ? 1 : 0 ), 1230 -sameSite => 'Lax', 1231 )); 1232 $info{'wrongip'} = 1; 1233 $auth_state = "failed"; 1234 } This correctly clears (without it I can log in to any branch on subsequent try) but does not create a new session ID, not sure how to fix this one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36934 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36941 Blocks|36941 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36941 [Bug 36941] Highlight that some libraries should not be available at login when StaffLoginRestrictBranchByIP is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36934 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43037 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36934 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens (kidclamp) from comment #1)

This correctly clears (without it I can log in to any branch on subsequent try) but does not create a new session ID, not sure how to fix this one

I think it kind of answers itself. Rather than clearing the value from the CGISESSID we should be creating an anonymous session and using the value from that. I'll have some code coming in bug 33259 to either fix this or make it easier... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.