[Bug 35911] New: Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Bug ID: 35911 Summary: Archived suggestions show in patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I don't know if this was meant as an enhancement or it's a regression, but since 22.11, archived suggestions show in the patron's "Suggestions" tab in the staff interface. It has been reported by many of our clients as a bug, so if it was intended, maybe we should add a syspref to hide them? To recreate: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible Prior to 22.11, archived suggestions were not visible in the patron's account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- If it was intended to show them, could we at least make them greyed out? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- And if it was intended to show them, could we add a filter? I would hide the archived suggestions by default and have a filter "Show archived suggestions", but that might change the current (unwanted in my case) behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, as patrons can't archive suggestions themselves it would make sense to me that they can see all suggestions they made and the status of them. I assumed archiving was for staff to have a means to reduce the number of suggestions in queues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Or do you mean only in staff? Maybe a checkbox "show archived" would be nice then in case they come to ask about already archived ones. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I meant in the staff interface, in the patron's account in the Suggestions tab. There is a discussion about seeing the archived suggestions in the OPAC in another bug (bug 27635). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #6 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 162403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162403&action=edit Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | Status|NEW |Needs Signoff CC| |shi-yao.wang@inLibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162403|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 162419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162419&action=edit Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I have signed off, as the test plan does what it says. For steps 9 and 10 I used the filter on the Acquisitions > Suggestion management page to include archived suggestions and then unarchived a suggestion. However, I think I would like to see a way to filter or show archived suggestions on the patrons suggestion page: - The message when they have no current suggestions is "This patron has not submitted any purchase suggestions", even though they may have archived suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32531 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162419|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162583&action=edit Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Definitely an unintended change in behaviour introduced by bug 23991. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an unintended release notes| |change introduced in Koha | |22.11. Archived suggestions | |are now no longer shown on | |the patron's account page | |in the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.04 |24.05.00,23.11.04,23.05.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org