[Bug 30127] New: By default show pending suggestions tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Bug ID: 30127 Summary: By default show pending suggestions tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 [Bug 7875] Pending suggestion link (the numbers) from staff client home directs to accepted suggestions instead of pending -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 130808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130808&action=edit Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- All the steps worked except #5. On step 5 - I created a new suggestion and saved it but the screen defaulted to the Accepted tab instead of the Pending tab. Also, editing and saving a suggestion defaulted to the Accepted tab instead of Pending. Since the Pending tab is the most important one I think it should be the first tab followed by Accepted and then any other tabs a library uses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130808|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134431&action=edit Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've changed how I do the fix, changing directly the perl so that pending is always the first tab. And added step 8 to test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- For me, after applying the patch and adding some suggestions, I no longer get any tabs displaying for suggestions by status (tried in Firefox and Google Chrome). I can post a screenshot if that doesn't make senses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #5)
For me, after applying the patch and adding some suggestions, I no longer get any tabs displaying for suggestions by status (tried in Firefox and Google Chrome).
I can post a screenshot if that doesn't make senses.
Ah indeed typo I repush patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134431|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134478&action=edit Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134478|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 134485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134485&action=edit Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears to work, but can you clarify where the behavior changed? When I test without the patches, the pending tab is also always the one displayed.
7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected
This one could be debatable, but it behaves like this already in my tests. Someone might expect that you see the same tab that you edited the suggestion from. So if you edit an accepted suggestion, you return to this tab. (absolute not blocker) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Never mind, I found my mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134485|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134714&action=edit Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org