http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 10575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10575&action=edit changed from login to login_controls in header.inc and staff-global.css I was wondering how this might affect other languages, as I was only testing English. Similar changes would need to be made for them, as header.inc and staff-global.css are in language dependent subdirectories. This would patch English. Perhaps login_controls isn't a good enough name? I'm open to something else, as long as it isn't login. Thank you. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You only have to correct the English files, all other languages are created from those files and the translations in the po files. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|oleonard@myacpl.org |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- The problem is the way cascading works. Renaming in place won't work. It needs to be below the ".clearfix" class. I was struggling for hours when I renamed in place, all because of the .clearfix class. I could put it in front of the #login_controls at the top if I wanted it in place, but it made more sense to be located with the other class that shares the header div. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11951|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12141&action=edit Renamed login to login_controls in header.inc and staff-global.css Caching of CSS files is a testing nightmare! Test ---- Before: 1) login 2) firebug the top right section div, it should be "login". 3) logout After patch: 1) login 2) firebug the top right section div, it should be "login_controls". WARNING: Make sure to trigger a reload of the CSS, otherwise a stale cache will have to screaming for hours. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12141|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12146&action=edit [SIGNED-OFF] Bug 8339 - div id="login" should be id="login_controls" in header.inc After experiencing what I believe was stale CSS, I have implemented oleonard's suggested fix which does work. That is: header.inc change login to login_controls, and in staff-global.css change the #login to #login_controls. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- The template file modules/auth.tt still use the login id for a div element. Please clarify if it is normal. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #11)

That's exactly the point. It removes the ambiguity between what <div id="login"> refers to. The <div> on auth.tt will now be identified differently than the <div> in the staff client header.

Ok thank you Owen. So I marked it as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.