[Bug 30108] New: Allow making hold dates required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Bug ID: 30108 Summary: Allow making hold dates required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Make it possible that the two hold dates on opac-reserve (starts on and not needed after) are mandatory. Enable OPACAllowHoldDateInFuture to see the first one. A new pref could include the various (4) combinations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 130745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130745&action=edit Bug 30108: Database revision, adding new preference Test plan: Run upgrade or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 130746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130746&action=edit Bug 30108: Preference description Test plan: Check the preferences form, tab Circulation, tab Hold policy. Look for OPACMandatoryHoldDates. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 130747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130747&action=edit Bug 30108: Allow making hold dates required Side note: Template still referred to class holddateto while not being used any longer. Replaced this occurrence by futuredate. Test plan: [1] Disable OPACAllowHoldDateInFuture. [2] Set pref OPACMandatoryHoldDates to "end date". [3] Verify that the end date is mandatory on opac-reserve. [4] Set pref OPACMandatoryHoldDates to "start date". [5] Verify that no dates are required. [6] Enable OPACAllowHoldDateInFuture. [7] Verify that start dates are required. [8] Set pref OPACMandatoryHoldDates to "no dates". [9] Verify that no dates are required again. Bonus: Check that more options box is opened when a date still is required. In case of item level being forced, verify that more options is opened regardless of pref setting. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Everything works as excepted but I think a few small things can be done to make the user experience easier: 1. On other OPAC pages (self-reg, suggestions ) we add a required div that makes it clear that the field is required: <div class="required_label required">Required</div> That would be nice so that users can see what is required. 2. The alert message 'Date should be filled.' is generic. We should tell the user exactly which field needs attention. The "Hold starts on date" field is required The "Hold not needed after" field is required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Marking Failed QA based on Lucas's comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131372&action=edit Bug 30108: (follow-up) Add required indication, differentiate alert As asked on comment4: [1] Add a required div as a visible hint when applicable. [2] Differentiate alert for hold start and end date. Test plan: See former patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4)
Everything works as excepted but I think a few small things can be done to make the user experience easier:
1. On other OPAC pages (self-reg, suggestions ) we add a required div that makes it clear that the field is required:
<div class="required_label required">Required</div>
That would be nice so that users can see what is required.
2. The alert message 'Date should be filled.' is generic. We should tell the user exactly which field needs attention.
The "Hold starts on date" field is required The "Hold not needed after" field is required
Thx Lucas for your testing and observations. Hope they are fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130745|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131376&action=edit Bug 30108: Database revision, adding new preference Test plan: Run upgrade or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130746|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131377&action=edit Bug 30108: Preference description Test plan: Check the preferences form, tab Circulation, tab Hold policy. Look for OPACMandatoryHoldDates. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130747|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131378&action=edit Bug 30108: Allow making hold dates required Side note: Template still referred to class holddateto while not being used any longer. Replaced this occurrence by futuredate. Test plan: [1] Disable OPACAllowHoldDateInFuture. [2] Set pref OPACMandatoryHoldDates to "end date". [3] Verify that the end date is mandatory on opac-reserve. [4] Set pref OPACMandatoryHoldDates to "start date". [5] Verify that no dates are required. [6] Enable OPACAllowHoldDateInFuture. [7] Verify that start dates are required. [8] Set pref OPACMandatoryHoldDates to "no dates". [9] Verify that no dates are required again. Bonus: Check that more options box is opened when a date still is required. In case of item level being forced, verify that more options is opened regardless of pref setting. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131372|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131379&action=edit Bug 30108: (follow-up) Add required indication, differentiate alert As asked on comment4: [1] Add a required div as a visible hint when applicable. [2] Differentiate alert for hold start and end date. Test plan: See former patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131378|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133462&action=edit Bug 30108: Database revision, adding new preference Test plan: Run upgrade or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133463&action=edit Bug 30108: Preference description Test plan: Check the preferences form, tab Circulation, tab Hold policy. Look for OPACMandatoryHoldDates. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133464&action=edit Bug 30108: Allow making hold dates required Side note: Template still referred to class holddateto while not being used any longer. Replaced this occurrence by futuredate. Test plan: [1] Disable OPACAllowHoldDateInFuture. [2] Set pref OPACMandatoryHoldDates to "end date". [3] Verify that the end date is mandatory on opac-reserve. [4] Set pref OPACMandatoryHoldDates to "start date". [5] Verify that no dates are required. [6] Enable OPACAllowHoldDateInFuture. [7] Verify that start dates are required. [8] Set pref OPACMandatoryHoldDates to "no dates". [9] Verify that no dates are required again. Bonus: Check that more options box is opened when a date still is required. In case of item level being forced, verify that more options is opened regardless of pref setting. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133465&action=edit Bug 30108: (follow-up) Add required indication, differentiate alert As asked on comment4: [1] Add a required div as a visible hint when applicable. [2] Differentiate alert for hold start and end date. Test plan: See former patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134476&action=edit Bug 30108: (follow-up) Make require label translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe in the future this could be rewritten with JQuery validator like opac-memberentry.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #18)
Pushed to master for 22.05, thanks to everybody involved 🦄
We are missing the update to the wiki here, but I am not seeing/finding the information about duration etc. right now: https://wiki.koha-community.org/wiki/Use_of_Cookies This documentation is important for libraries dealing with GDPR. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wrong bug... too many tabs. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org