[Bug 8804] New: Quiet errors in the log from Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Priority: P5 - low Change sponsored?: --- Bug ID: 8804 Assignee: oleonard@myacpl.org Summary: Quiet errors in the log from Auth.pm Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha Use of uninitialized value $sessiontype in string eq at C4/Auth.pm line 705. Use of uninitialized value $opac_search_limit in pattern match (m//) at C4/Auth.pm line 384. Use of uninitialized value in pattern match (m//) at C4/Auth.pm line 384. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12450&action=edit Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12450|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 12458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12458&action=edit [SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Signed-off-by: Marc Veron <veron@veron.ch> I could reproduce both errors with the staff client, not with the Opac. After applying the patch no more log entries regarding line 705 and line 384, so I sign off this patch. However I had one more similar log entry (with and without patch) that could be addressed in a follow up: mainpage.pl: Use of uninitialized value $pki_field in string eq at (...)/C4/Auth.pm line 736., referer: http://(...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 12458 [details] [SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm
Signed-off-by: Marc Veron <veron@veron.ch>
trivial patch, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * 445bcca Bug 8804 - Quiet errors in the log from Auth.pm C4/Auth.pm * C4/Auth.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: OK, i'm a little bit excessive, but that's what QA is made for ;-) Unless i'm mistaking, there is a useless () + if ((($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/) && $opac_limit_override) || ($in->{'query'}->param('limit') && $in->{'query'}->param('limit') =~ /branch:(\w+)/)){ can be written + if (($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/ && $opac_limit_override) || ($in->{'query'}->param('limit') && $in->{'query'}->param('limit') =~ /branch:(\w+)/)){ => if ((A && B && C) || (D && E)) am I right ? If yes, please fix & resubmit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12458|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13075&action=edit Bug 8804 [Revised] Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Revision simplifies logic as per RM suggestion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13075|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13183&action=edit Bug 8804 [Revised] Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Revision simplifies logic as per RM suggestion. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- As Marc says, there are a few other warnings, but this patch does not claim to fix them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
Created attachment 13183 [details] Bug 8804 [Revised] Quiet errors in the log from Auth.pm
Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence.
Errors appeared when logged in and viewing a detail page in the OPAC.
Revision simplifies logic as per RM suggestion.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
patch works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit ea72919) * 3460a37 Bug 8804 [Revised] Quiet errors in the log from Auth.pm C4/Auth.pm * C4/Auth.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org