[Bug 5408] New: Refactor C4::Circulation::GetIssuingRule
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Summary: Refactor C4::Circulation::GetIssuingRule Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: cfouts@liblime.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 GetIssuingRule submits a cascade of queries to the database to find its match. This could be optimized and cleaned up by retrieving them all at once. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Clay Fouts <cfouts@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |cfouts@liblime.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 --- Comment #1 from Clay Fouts <cfouts@liblime.com> 2010-11-15 08:23:46 UTC --- Created attachment 2752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2752 Patch to refactor GetIssuingRule -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Clay Fouts <cfouts@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Clay Fouts <cfouts@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-10 10:23:06 UTC --- This bug is mentioned in: Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013006.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013007.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013020.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013025.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013043.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013044.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013057.... Bug 5408 - Refactor GetIssuingRule and GetLoanLength http://lists.koha-community.org/pipermail/koha-patches/2010-November/013021.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Patch doesn't apply |ASSIGNED Version|rel_3_4 |master Assignee|cfouts@liblime.com |gmcharlt@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Is this bug still valid? I assume the patch will never be rebased by the original author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #3)
Is this bug still valid? I assume the patch will never be rebased by the original author.
Unlikely I agree, should we close this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 --- Comment #5 from Clay Fouts <cfouts@liblime.com> --- If you refer to the mailing list comments linked from here, I was told that Biblibre's approach to optimizing this section was being preferred over mine. Surprising that in two year's time neither my code nor theirs has actually been adopted to treat this poorly constructed functionality. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |WONTFIX --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- WONTFIXING this approach as Koha has changed quite a bit since 2010... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org