https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #1 from Joseph Alway <jbalway@gmail.com> --- The historty.txt file is missing. Not sure why, but it is. In an older version of Koha, the file is there. In the current install it's just missing. Haven't gotten around to checking the Virtual Machine I was testing, before our current install. It may just be an issue with our install? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Laura Escamilla from comment #0)

When viewing the timeline tab on the "About Koha" page, the error: "Could not read the history.txt file. Please make sure <docdir> is correctly defined in koha-conf.xml." shows up.

hi Laura this indicates that you seem to be missing a <docdir> definition in a koha installed with a debian package, the following line should exist in your /etc/koha/sites/mykoha1/koha-conf.xml <docdir>/usr/share/doc/koha-common</docdir> fyi: the history file should exist at /usr/share/doc/koha-common/history.txt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #5)

Hi Mason,

it looks like this is not a singular/one installation issue. Our package installations of 22.11 are missing the file as well. It looks like a general issue with the package installations.

hmm, the file exists in 22.11.03 package ---------- # apt install koha-common # apt policy koha-common koha-common: Installed: 22.11.03-1 Candidate: 22.11.03-1 Version table: *** 22.11.03-1 500 500 http://debian.koha-community.org/koha 22.11/main amd64 Packages 100 /var/lib/dpkg/status # dpkg -L koha-common | grep history.txt /usr/share/doc/koha-common/history.txt # ls -l /usr/share/doc/koha-common/history.txt -rw-r--r-- 1 root root 113207 Mar 1 01:54 /usr/share/doc/koha-common/history.txt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Happens on our freshly packaged 22.11.03 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I'm a bit behind these days but I should be looking at 22.11 Deb package installs in the near future... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #9)

(In reply to Katrin Fischer from comment #8)

...

Happens on our freshly packaged 22.11.03

I'm going to set the version to 22.11 as 22.05 is fine and master ktd is OK.

I believe it's a packages thing because the file is not ending up where it should be, so it's not being copied/installed into the right spot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Katrin: Is this a vanilla Debian package or is this one that you packaged? I'm running a vanilla 22.05 and I see the history.txt, but I've looked again at my custom 21.11 and I do *not* see the history.txt. Now I would've sworn that my 21.11 instances had a history.txt before, but looking today it is certainly gone. (However, I still see teams.yaml and contributors.yaml in /usr/share/doc/koha-common...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- # dpkg -l koha-common Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-============-============-=============================================== ii koha-common 22.05.08-2 all integrated (physical) library management system # dpkg -L koha-common | grep "history.txt" /usr/share/doc/koha-common/history.txt ----------------------------------------------------- # dpkg -l koha-common Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-========================================-============-=============================================== ii koha-common 22.12.00-9~git+20230228053212.66e9bc71-1 all integrated (physical) library management system # dpkg -L koha-common | grep "history.t -------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Interestingly my custom 21.11 had /usr/share/doc/koha-common/history.txt back in March 2022 but not in March 2023... Not noticing anything obvious in the git repo that would've caused a change... I think I may have made some build machine changes during that time so maybe that's related... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- If I make a tarball from custom 21.11, I see docs/history.txt is in there... But when I build from that same branch, the history.txt file is not in the .deb package. I can confirm that using 'dpkg -c' on the .deb file. -- It looks like it's being installed by dh_auto_install into the '/debian/tmp' build directory... Installing /home/koha/build/koha-21.11.XX-XXXX+20230320095638.5d5cedcd/debian/tmp/usr/share/koha/doc/teams.yaml Installing /home/koha/build/koha-21.11.XX-XXXX+20230320095638.5d5cedcd/debian/tmp/usr/share/koha/doc/contributors.yaml Installing /home/koha/build/koha-21.11.XX-XXXX+20230320095638.5d5cedcd/debian/tmp/usr/share/koha/doc/history.txt However in debian/rules, we nuke /usr/share/koha/doc since we don't need it in /usr/share/koha... so that's irrelevant. Just shows that it does exist at that point in time... -- I don't know. It's so weird that teams.yaml and contributors.yaml get included but history.txt does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #21 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #20)

(In reply to David Cook from comment #15)

...

ii koha-common 22.12.00-9~git+20230228053212.66e9bc71-1 all integrated (physical) library management system

# dpkg -L koha-common | grep "history.t

--------------------------------------------------

seems to be working ok on the latest master/dev branch

hmm, i think ive traced the problem to using deb9 vs deb10 pbuilder versions, (wtf) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Looking back at 20.11, it looks like /usr/share/doc/koha-common/changelog.gz and /usr/share/doc/koha-common/history.txt are the same (except changelog.gz is obviously compressed) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- Ok if we compare different versions of dh_installchangelogs (thank you open source), we can see that the rename didn't happen back in the Stretch version: https://github.com/Debian/debhelper/blob/debian/10.2.5/dh_installchangelogs https://github.com/Debian/debhelper/blob/master/dh_installchangelogs Looks like the change was introduced in debian 11.3 I think: https://github.com/Debian/debhelper/commit/406bd37eb4692e172fbf6c3c390cb4f50... What a nice little breaking change hehe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- Hmm I bet a number of the release tools look for history.txt. Maybe renaming is actually going to be more work... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- As predicted, we regain /usr/share/doc/koha-common/history.txt at the expense of /usr/share/doc/koha-common/changelog.gz I think that's fine. I've noticed a number of packages that have "changelog.Debian.gz" but not "changelog.gz" or their changelog.gz is the same as "changelog.Debian.gz". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Created attachment 148497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148497&action=edit Bug 33168: Prevent debhelper from renaming history.txt to changelog This change prevents debhelper from renaming history.txt to changelog, since that renaming was breaking the Timeline feature in Koha. Another option would've been to rename history.txt to something else but that filename is already embedded in Koha and the Koha release tools, so this seems the safer option. Test plan: 0. Apply patch 1. Build Debian package 2. Confirm that /usr/share/doc/koha-common/history.txt is created and /usr/share/doc/koha-common/changelog.gz is not created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Timeline on "About Koha" is |Timeline on "About Koha" is |not working |not working for package | |installs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #33 from Mason James <mtj@kohaaloha.com> ---

Signed-off-by: Mason James <mtj@kohaaloha.com>

tested as working on deb10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #34)

It looks like this required quite a bit of detectice work - thanks a lot!

A hunch and some lucky searching heh Since Mason and I have already worked on this one, how do we move this along through QA? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #37 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #36)

1. Build Debian package

What's the easiest for that steps (in March 2023)?

hi Jonathan try this wiki page, its been updated recently https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way update us, if you have any problems :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148501|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148632&action=edit Bug 33168: Prevent debhelper from renaming history.txt to changelog This change prevents debhelper from renaming history.txt to changelog, since that renaming was breaking the Timeline feature in Koha. Another option would've been to rename history.txt to something else but that filename is already embedded in Koha and the Koha release tools, so this seems the safer option. Test plan: 0. Apply patch 1. Build Debian package 2. Confirm that /usr/share/doc/koha-common/history.txt is created and /usr/share/doc/koha-common/changelog.gz is not created Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In full trust :) And covered by what I found here: The upstream changelog is automatically found by the dh_installchangelogs using the case insensitive match of its file name to changelog, changes, changelog.txt, changes.txt, history, history.txt, or changelog.md and searched in the ./ doc/ or docs/ directories. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 149055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149055&action=edit Bug 33168: (follow-up) Swap spaces for tabs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #43 from David Nind <david@davidnind.com> --- I tested the follow-up patch as follows using KTD: 1. Open debian/rules in a text editor with tabs and spaces displayed. 2. Note that on lines 51 and 52 that spaces are used instead of tabs. 3. Apply the follow-up patch only (the main patch is already in master). 4. Note that the spaces in step 2 are now tabs. I hope this is sufficient. I also amended the commit message to follow the title conventions for follow-up patches. Note: I also noticed that for lines 43 and 44 that spaces are used after the first tab - do these need to be fixed as well? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #42)

Created attachment 149055 [details] [review] Bug 33168: (follow-up) Swap spaces for tabs

Signed-off-by: David Nind <david@davidnind.com>

Pushed to master for 23.05.00. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #47 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki@biblibre.com --- Comment #49 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes.