[Bug 12899] New: Row grouping in checkouts table is alphabetical and layout depends on words chosen in translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Bug ID: 12899 Summary: Row grouping in checkouts table is alphabetical and layout depends on words chosen in translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In checkouts.js the checkouts table is being built and the rows are grouped ascending alphabetically into "Today's checkouts" and "Previous checkouts". The problem is that in translations where the words are different sorting "asc" can change the layout so that previous checkouts are on top and hides todays. Very impractical. .rowGrouping is the culprit. Thanks to Owen and Kyle for troubleshooting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31502&action=edit Bug 12899 - Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31502|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31511&action=edit Bug 12899 - Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- If the export column is displayed (I didn't try without this column), the columns are misplaced. Instead of adding a new column, what about a "<span title=''></span>", it does not work? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31511|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31599&action=edit Bug 12899 [Revised] Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31599|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31620&action=edit Bug 12899 [Revised] Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31620|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31621&action=edit Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12963 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12899 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org