[Bug 40964] New: koha-elasticsearch is missing --where option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Bug ID: 40964 Summary: koha-elasticsearch is missing --where option Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: domm@plix.at QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz misc/search_tools/rebuild_elasticsearch.pl has an option --where to pass arbitrary SQL to select which records to index. The koha-elasticsearch wrapper script is missing this option. Add it! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 --- Comment #1 from Thomas Klausner <domm@plix.at> --- Created attachment 187530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187530&action=edit Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns@gwdg.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187530|0 |1 is obsolete| | --- Comment #2 from Anke Bruns <anke.bruns@gwdg.de> --- Created attachment 187555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187555&action=edit Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest Signed-off-by: John Doe <you@example.com> Signed-off-by: Anke Bruns <anke.bruns@gwdg.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 --- Comment #3 from Thomas Klausner <domm@plix.at> --- see also #35345 (the actual implementation in rebuild_elasticsearch.pl) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|koha-bugs@lists.koha-commun |domm@plix.at |ity.org | Depends on| |35345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345 [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl to determine which records to index -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187555|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188361&action=edit Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest Signed-off-by: Anke Bruns <anke.bruns@gwdg.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188362&action=edit bug 40964: Add long version of options to man Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Removed John Doe's signed-off-by line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please fix this commit message: bug 40964: Add long version of options to man * Commit title does not start with 'Bug XXXXX: ' - 7031c83280b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188362|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189001&action=edit Bug 40964: Add long version of options to man Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |lukasz.koszyk@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40964 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org