[Bug 14968] New: found shouldn't be set to null when cancelling holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Bug ID: 14968 Summary: found shouldn't be set to null when cancelling holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We want to provide statistics on canceled holds to know if they haven't been picked-up while waiting for the borrower or if the expiration_date on hold have been passed. But if we can see if a hold is waiting in found column of reserves table, this information disappeared from old_reserves table. Found shouldn't be set to Null when cancelling in order to keep this information in old_reserves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 43173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43173&action=edit found shouldn't be set to null when cancelling holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Test plan : - fill syspref ReservesMaxPickUpDelay = 0 - Add a hold and return the item to make it waiting for the borrower - Wait one day or change waitingdate in reserves table to put yesterday date - launch the script /src/misc/cronjobs/holds/cancel_expired_holds.pl You should find your reserve in old_rerseves table with W in column found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by JM Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43173|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 45775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45775&action=edit Bug 14968 - found shouldn't be set to null when cancelling holds Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide a regression test for this change and provide use case. Why do you want to look at this value when the reserve has been removed (just a curious question :))? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I think it's for statistics: filled vs. cancelled holds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Yes, we want to have statistics to know if holds have been cancelled because they have never been available or because they've not been picked up by the borrower. We can also imagine having different notices to warn borrowers that their holds have been cancelled : text can be different if the document isn't available or if the document was waiting but the borrowers didn't come to take it in time. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org