[Bug 10761] New: UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Bug ID: 10761 Summary: UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt@gmail.com Reporter: kenza.zaki@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki@biblibre.com Depends on| |3134 Assignee|gmcharlt@gmail.com |kenza.zaki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 20460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20460&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20460|0 |1 is obsolete| | --- Comment #2 from kenza <kenza.zaki@biblibre.com> --- Created attachment 20464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20464&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20464|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20515&action=edit [SIGNED OFF] Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, tested with patch for bug 10761 applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I found some improvements for this routine, I will submit a qa followup. If the $sth->finish statement is removed (see bug 3134 comment 24), it is possible to know how many rows are affected by the DELETE query. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20515|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20530&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, tested with patch for bug 10761 applied. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20531&action=edit Bug 10761: UT: Improvement for Reports_guided.t 1/ delete_report should return undef is no parameter is given. 2/ delete_report returns the number of affected rows. 3/ delete_report should be tested with 1 and more parameters. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up to explicitly return from C4::Reports::Guided::delete_report(). Thanks, Kenza and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org