https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UseCashRegisters gets |UseCashRegisters gets |ignored on paycollect |ignored on paycollect when | |change > 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 [Bug 42287] Tidy all script tags - members -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 198354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198354&action=edit Bug 42466: Fix ignored form validation on paycollect When UseCashRegisters is enabled and a change value bigger than 0 exists (the amount tendered is bigger than the amount paid) the form could be submitted without a required cash register. The modal dialog informing of the change value would simply ignore missing other required fields. Also warnings on 'Amount tendered' did not disappear when 'Amount being paid' was set to a higher value and later reset to a lower value than 'Amount tendered'. This patch fixes both issues by moving the modal dialog (confirm change money) to the form validations submit handler and by validating the form on each update of 'Amount tendered' or 'Amount being paid'. Test plan: a) enable UseCashRegisters and create one under /cgi-bin/koha/admin/cash_registers.pl?op=add_form b) create a manual fee (f.e. 10) f.e. via /cgi-bin/koha/members/maninvoice.pl?borrowernumber=16 c) There are several ways to reach the 'Pay an amount toward all charges' form: - Patron -> Accounting -> (Tab) Make a payment - Patron -> Details -> Attention -> Pay all charges d) enter the follwing values - Amount being paid: 7 - Amount tendered: 6 -> a warning will appear : Please enter a value greater than or equal to 7. e) set - Amount being paid: 5 -> The warning remains visible: Please enter a value greater than or equal to 7. f) Click confirm -> Modal which wants you to confirm that there is a change left. g) Click yes. The form will be sent even though the required filed 'Payment type' is not set. h) go to the payments form again. Total amount outstanding should be 5.00 now enter the following so that change is > 0.00 - Amount being paid: 3 - Amount tendered: 4 - Payment type: Cash i) Click confirm -> Modal which wants you to confirm that there is a change left. j) Click yes. You will see an Error trace page As long as 'Change to give' is other than 0.00 you will be able to send the form. Apply patch: l) repeat b) until e) and check that the warning disappears when Amount being paid is lower or equal than Amount tendered m) check that clicking Confirm will not send the form n) check that when Payment type is set to Cash, the Cash register is required to send the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 198381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198381&action=edit Bug 42466: Fix ignored form validation on paycollect When UseCashRegisters is enabled and a change value bigger than 0 exists (the amount tendered is bigger than the amount paid) the form could be submitted without a required cash register. The modal dialog informing of the change value would simply ignore missing other required fields. Also warnings on 'Amount tendered' did not disappear when 'Amount being paid' was set to a higher value and later reset to a lower value than 'Amount tendered'. This patch fixes both issues by moving the modal dialog (confirm change money) to the form validations submit handler and by validating the form on each update of 'Amount tendered' or 'Amount being paid'. Test plan: a) enable UseCashRegisters and create one under /cgi-bin/koha/admin/cash_registers.pl?op=add_form b) create a manual fee (f.e. 10) f.e. via /cgi-bin/koha/members/maninvoice.pl?borrowernumber=16 c) There are several ways to reach the 'Pay an amount toward all charges' form: - Patron -> Accounting -> (Tab) Make a payment - Patron -> Details -> Attention -> Pay all charges d) enter the follwing values - Amount being paid: 7 - Amount tendered: 6 -> a warning will appear : Please enter a value greater than or equal to 7. e) set - Amount being paid: 5 -> The warning remains visible: Please enter a value greater than or equal to 7. f) Click confirm -> Modal which wants you to confirm that there is a change left. g) Click yes. The form will be sent even though the required filed 'Payment type' is not set. h) go to the payments form again. Total amount outstanding should be 5.00 now enter the following so that change is > 0.00 - Amount being paid: 3 - Amount tendered: 4 - Payment type: Cash i) Click confirm -> Modal which wants you to confirm that there is a change left. j) Click yes. You will see an Error trace page As long as 'Change to give' is other than 0.00 you will be able to send the form. Apply patch: l) repeat b) until e) and check that the warning disappears when Amount being paid is lower or equal than Amount tendered m) check that clicking Confirm will not send the form n) check that when Payment type is set to Cash, the Cash register is required to send the form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42986 [Bug 42986] JS error when writing off selected charges -- You are receiving this mail because: You are watching all bug changes.