[Bug 17987] New: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Bug ID: 17987 Summary: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Rather than a free text syspref where a user can easily put in a category that doesn't exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59591&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=17897 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11536 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59591|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59592&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Could this show the description instead of the code? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59592|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59635&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59635|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 59640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59640&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Aleisha, Here are a few remarks: 1/ in the preferences.pl file, I think it would be better to affect the patron category list to $chunk->{'CHOICES'} if the type of the syspref is patron-categories, and not depending on its name. That way it will be reusable more easily. 2/ There is type=PatronCategories"in the DB, choices:patron-categories in the opac.pref, then choices eq 'patron-categories' in preferences.pl How is useful this type=PatronCategories? 3/ There are 2 problematic cases: a. The field is not filled yet: it's not visible on the interface, there is no blank entry b. A bit more tricky: if the patron category has been removed, it will not be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** This bug has been marked as a duplicate of bug 27634 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org