[Bug 10444] New: In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Bug ID: 10444 Summary: In advanced search(more), [+] and [-] should behave like links on hover Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18836&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18847&action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18836|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18851&action=edit [SIGNED-OFF] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18847|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18852&action=edit [SIGNED-OFF] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18851|0 |1 is obsolete| | Attachment #18852|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18900&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the onclick event on the 2 links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18901&action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18901|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18902&action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works as expected except for the click reset the scroll at the top. I amended the patch in order to add a onclick and to trigger the event. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #8)
QA comment: Works as expected except for the click reset the scroll at the top. I amended the patch in order to add a onclick and to trigger the event. Marked as Passed QA.
I'm not quite sure that your amendment was attached to this bug -- please double-check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18900|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18906&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the onclick event on the 2 links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- I disagree with how the QA modification was implemented. Rather than adding onclick attributes, the existing jQuery click handlers should be modified to return false. Doing it that way is more consistent with our current push for unobtrusive Javascript. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #11)
I disagree with how the QA modification was implemented. Rather than adding onclick attributes, the existing jQuery click handlers should be modified to return false. Doing it that way is more consistent with our current push for unobtrusive Javascript.
Yes of course, but nodes are generated after the load of the page. So I thought it would be difficult. But in fact no, I will resubmit patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18851|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18851|0 |1 is obsolete| | Attachment #18902|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18918&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18919&action=edit Bug 10444: Fix prevent the default action on click -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm afraid the link underlines still shows for the ccsr theme. Please add a followup to modify the ccsr css as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18902|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #15)
I'm afraid the link underlines still shows for the ccsr theme. Please add a followup to modify the ccsr css as well.
My fault, I obsoleted it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18902|0 |1 is obsolete| | Attachment #18918|0 |1 is obsolete| | Attachment #18919|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18991&action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18992&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18993&action=edit Bug 10444: Fix prevent the default action on click Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> ---
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
So, marked as Passed QA :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18991|0 |1 is obsolete| | Attachment #18992|0 |1 is obsolete| | Attachment #18993|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18997&action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18998&action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18999&action=edit Bug 10444: Fix prevent the default action on click Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org