[Bug 10070] New: Anonymous searches are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug ID: 10070 Summary: Anonymous searches are broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com If no user is connected at the OPAC, and the pref EnableOpacSearchHistory is turn on, the history search should be accessible. It is not the case in master. git bisect says me that this commit is guilty: d542740ab8877234d043c8a11cb19a6004e72656 is the first bad commit commit d542740ab8877234d043c8a11cb19a6004e72656 Author: Dobrica Pavlinusic <dpavlin@rot13.org> Date: Sun Jun 10 15:18:42 2012 +0100 Bug 6554 - make Koha internally utf-8 clean -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17499&action=edit Bug 10070: Anonymous searches are broken Test plan: 1 - turn on EnableOpacSearchHistory 2 - launch some searches at the opac 3 - go to your search history 4 - there is no history! 5 - apply this patch 6 - retry steps 1 to 3 7 - your history search is available! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Summary|Anonymous searches are |History of anonymous |broken |searches is not keep Severity|blocker |major --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Bug title is quite misleading, you can search, just the history is not saved, testing patch now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|History of anonymous |History of anonymous |searches is not keep |searches is not kept -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- I also worry this is not the only thing the utf8 changes have broken, however they are probably too buried to revert now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17499|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17514&action=edit Bug 10070: Anonymous search history is not being set in the cookie Test plan: 1 - turn on EnableOpacSearchHistory 2 - launch some searches at the opac 3 - go to your search history 4 - there is no history! 5 - apply this patch 6 - retry steps 1 to 3 7 - your history search is available! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This does fix the bug, but does undo the change to make the cookie utf-8 safe, however I think that change was done in the wrong way so I am happy to sign this off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6554 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17514|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17666&action=edit [PASSED QA] Bug 10070: Anonymous search history is not being set in the cookie Test plan: 1 - turn on EnableOpacSearchHistory 2 - launch some searches at the opac 3 - go to your search history 4 - there is no history! 5 - apply this patch 6 - retry steps 1 to 3 7 - your history search is available! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This does fix the bug, but does undo the change to make the cookie utf-8 safe, however I think that change was done in the wrong way so I am happy to sign this off Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Wondering if the comment line should be deleted now too. Patch fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, since you reverted patches for bug 6554, this patch should be reverted from 3.12 branch too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #7)
Jared, since you reverted patches for bug 6554, this patch should be reverted from 3.12 branch too.
Are you sure? If I revert this patch the search history ceases to function. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8)
(In reply to comment #7)
Jared, since you reverted patches for bug 6554, this patch should be reverted from 3.12 branch too.
Are you sure? If I revert this patch the search history ceases to function.
Ho yes sorry, you are right. However there is an issue: 1/ logout 2/ search "bar" (added to the history) 3/ search "féé" => history is empty -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Whaou, in fact the solution is easy, the function to call is uri_escape (what it was before bug 6554). uri_escape_utf8 was introduced by bug 6554 and this patch fixed the issue but not for utf8 characters. So in 3.12, if you revert this one, it will introduce the uri_escape_utf8 call :) So I will provide 1 patch for 3.12 and 1 for master. I think it is not useful to open a new report, say me if you disagree. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17709&action=edit Bug 10070: [3.12.x] revert previous changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17710&action=edit Bug 10070: revert previous changes We should use escape_uri instead of escape_uri_utf8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17709|Bug 10070: [3.12.x] revert |[3.12] Bug 10070: [3.12.x] description|previous changes |revert previous changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17710|Bug 10070: revert previous |[master] Bug 10070: revert description|changes |previous changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- With these 2 patches I can search several terms (with utf8 characters) and keep my anonymous history searches on 3.12 and master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17709|0 |1 is obsolete| | Attachment #17710|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|jonathan.druart@biblibre.co |chris@bigballofwax.co.nz |m | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17774&action=edit Signed off patch Both patches work for both master and 3.12.x so have just signed off one and obsoleted them both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17779&action=edit [PASSED QA] Bug 10070: revert previous changes To test 1/ logout 2/ search "bar" (added to the history) 3/ search "féé" => history is empty Apply patch 1/ logout 2/ search "bar" (added to the history) 3/ search "féé" => added to the history Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch only works on 3.12.x for me, even after 6554 has been reverted from master. I am going to push it to master, and defer a decision about what to do with this bug in master to the 3.14 RM. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed directly to 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #16)
This patch only works on 3.12.x for me, even after 6554 has been reverted from master. I am going to push it to master, and defer a decision about what to do with this bug in master to the 3.14 RM.
The binmode line in C4/Output.pm makes the difference in sub output_html_with_http_headers. Remove it from master. I wasn't too happy with a binmode there anyway.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org