[Bug 21201] New: C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Bug ID: 21201 Summary: C4::Items - Remove GetItemnumbersForBiblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org my $itemnumbers = GetItemnumbersForBiblio($biblionumber); will become my $itemnumbers = [ Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") ]; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77685&action=edit Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77686&action=edit Bug 21201: Remove GetItemnumbersForBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77685|0 |1 is obsolete| | Attachment #77686|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77964&action=edit Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77965&action=edit Bug 21201: Remove GetItemnumbersForBiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77964|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78114&action=edit Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77965|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78115&action=edit Bug 21201: Remove GetItemnumbersForBiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Bug 21201 depends on bug 21184, which changed state. Bug 21184 Summary: C4::Items - Remove GetBarcodeFromItemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org