[Bug 7292] New: new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Bug #: 7292 Summary: new permission for claims Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: claire.hernandez@biblibre.com ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com Blocks: 7163 "new permission for claims: the librarian can have a permission ""claim for all"". Without this permission, he can claim only on basket he is a ""user"" of " (BibLibre MT6542) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |7295 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|claire.hernandez@biblibre.c |julian.maurice@biblibre.com |om | --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9618&action=edit More granular permissions for claiming orders Add a new permission order_claim_for_all. Without this permission, user can only claim for orders in baskets he's authorised to manage (depends on bug 7295) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- To test: - Apply patch for bug 7295 first and apply this patch - Run the updatedatabase.pl script - Go to acqui/lateorders.pl Checkboxes in last column must display only if you are an authorised user of the order's basket (creator, user, or connected to same branch as the basket branch, see bug 7295 for more details) - Grant permission 'order_claim_for_all' to your user and go back to acqui/lateorders.pl You must be able to claim for all displayed orders. Without GranularPermissions sysprefs, 'acquisition' permission should allow you to claim for all orders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I think this is a similar situation as we have for baskets. For baskets you can currently set globally if - you can see only your own baskets - all baskets of your branch - all baskets in the system So I was thinking if we should have somthing similar for claiming. It might make sense to have an option to only be able to claim orders of your own library/branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, Actually, this patch prevent users to claim on baskets they're not authorised to manage. So it take into account the AcqViewBaskets system preference: - If 'all', user can claim for all orders - If 'branch', user can claim for basket of his branch - If 'user', user can claim for baskets he own or he's a 'user' of I think we don't need another system preference here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, thinking about the possible cases: If the user can not manage baskets at all or can only manage basket he/she created and has the permission to claim all order - he/she will always be able to claim all baskets from all branches, is that right? And I like that this is a permission, not a system preference :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #6)
Hm, thinking about the possible cases:
If the user can not manage baskets at all or can only manage basket he/she created and has the permission to claim all order - he/she will always be able to claim all baskets from all branches, is that right?
That's right, 'order_claim_for_all' is like a 'superlibrarian' permission for claims. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Applying: Bug 7292: More granular permissions for claiming orders fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/userpermissions.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9618|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10968&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Same error with this one: Applying: Bug 7292: More granular permissions for claiming orders fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/userpermissions.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10968|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11284&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master Just a reminder: this patch needs patch(es) (at least the first) from bug 7295 in order to work (and apply correctly) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11284|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14518&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #13 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 7292: More granular permissions for claiming orders Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7292: More granular permissions for claiming orders The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14518|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21354&action=edit Bug 7292: More granular permissions for claiming orders Add a new permission order_claim_for_all. Without this permission, user can only claim for orders in baskets he's authorised to manage (depends on bug 7295) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Bot Control|--- |Ignore this bug --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Patch recreated on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/userpermissions.sql). Please provide 1 file for DB changes and 1 file (at least) for others changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25078&action=edit Bug 7292: New permission for claims (database changes only) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21354|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25079&action=edit Bug 7292: More granular permissions for claiming orders Add a new permission order_claim_for_all. Without this permission, user can only claim for orders in baskets he's authorised to manage -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Patches split and rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Bug 7292 depends on bug 7295, which changed state. Bug 7295 Summary: list of librarian managing a basket http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #20 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I try first with a user who haven't the permission "order_claim_for_all Claim for all orders". On the table of Late orders,the user have checkbox in front of the order line from basket that he've created or that he was added in the list of users authorized for management of this basket. He can see the other line order but he can't check it for claims. I change the permissions to add "order_claim_for_all Claim for all orders". The users can check all the order, even those he haven't created or he doesn't manage. Ok for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It might be silly, but I am wondering a bit about the code for the new permission - order_claims_for_all, we have so far: budget_manage_all order_manage_all claim_serials So I think claim_order_all or order_claims_all would have been a bit more consistent. ... But I am going to continue with QA :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26355&action=edit [PASSED QA] Bug 7292: New permission for claims (database changes only) Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Added sign off according to bugzilla. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26356&action=edit [PASSED QA] Bug 7292: More granular permissions for claiming orders Add a new permission order_claim_for_all. Without this permission, user can only claim for orders in baskets he's authorised to manage Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with: - AcqViewBaskets system preference - order_manage_all permission - order_claims_for_all permission Test plan: Each staff member is only allowed to manage their own baskets (AcqViewBaskets).
From the 2 test users, none has order_manage_all or order_claims_for_all.
In acquisitions vendor search, each can see their own baskets only - OK. On the late orders page, both can see all orders, but can only claim their own. - OK When one of the users is given order_claims_for_all - all orders can be claimed. - OK When AcqViewBaskets is set to 'in system, regardless of owner' all orders can be claimed by both users. OK Passes tests and QA script. Going to provide a follow up with the German translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26357&action=edit Bug 7292: German translation for new 'claim for all' permission Translates the description of the new user permission 'order_claim_for_all' to German. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I had passed it, but then it occured to me, that introducing this new permission will mean taking away permissions for existing users as we don't update those. Could you make sure that we set the permission for existing staff users in the database update? I think from what I see in the template that would be all users having order_receive permission? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 26677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26677&action=edit Bug 7292: Add new permission to users that have 'order_receive' permission -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- You're right Katrin, this patch modify updatedatabase.pl to add automatically the new permission. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #28 from Paola Rossi <paola.rossi@cineca.it> --- I try to apply against master 3.15.00.052 I think that the patches need to be rebased. I could resolve the CONFLICT on the first patch: Applying: Bug 7292: New permission for claims (database changes only) Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql Auto-merging installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql Auto-merging installer/data/mysql/pl-PL/mandatory/userpermissions.sql Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql Auto-merging installer/data/mysql/it-IT/necessari/userpermissions.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql Auto-merging installer/data/mysql/es-ES/mandatory/userpermissions.sql Auto-merging installer/data/mysql/en/mandatory/userpermissions.sql Auto-merging installer/data/mysql/de-DE/mandatory/userpermissions.sql Failed to merge in the changes. Patch failed at 0001 Bug 7292: New permission for claims (database changes only) Anyway, the second patch doesn't apply: Applying: Bug 7292: More granular permissions for claiming orders Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt I pass the patches to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26355|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28462&action=edit Bug 7292: New permission for claims (database changes only) Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26356|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28463&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26677|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28464&action=edit Bug 7292: Add new permission to users that have 'order_receive' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26357|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28465&action=edit Bug 7292: German translation for new 'claim for all' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- I test against master 3.17.00.007 The patch adds the new permission to users that have 'order_receive' permission: OK. updatedatabase.pl needs to be rebased. The test is OK. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28462|0 |1 is obsolete| | --- Comment #34 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28484&action=edit New permission for claims (database changes only) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28463|0 |1 is obsolete| | --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28485&action=edit More granular permissions for claiming orders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28464|0 |1 is obsolete| | --- Comment #36 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28486&action=edit Add new permission to users that have 'order_receive' permission -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28465|0 |1 is obsolete| | --- Comment #37 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28487&action=edit German translation for new 'claim for all' permission -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same here as for the other permission, could you please update to use the new superlibrarian check? +if ($userflags->{superlibrarian} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28484|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30341&action=edit Bug 7292: New permission for claims (database changes only) Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28485|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30342&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28486|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30343&action=edit Bug 7292: Add new permission to users that have 'order_receive' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28487|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30344&action=edit Bug 7292: German translation for new 'claim for all' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30345&action=edit Bug 7292: Use IsSuperLibrarian() instead of $userflags->{superlibrarian} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note from code review: - $template->{VARS}->{'info_claim'} = 1; + $template->param(info_claim => 1); The first line was correct (TT), the second is still working (HTP), but outdated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The database update works very nicely, seeting the permissions. But when I tried retesting the feature itself, I have run into problems: - AcqViewBaskets: created or managed by staff user - Staff patron doesn't have claim_for_all permission - aqorders.branch != staff patron home branch - aqorders.authorisedby != staff patron borrowernumber - Tried logging in and out after making the changes. ... and it still shows up in the late orders list. What am I missing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #46 from Julian Maurice <julian.maurice@biblibre.com> --- Patron should also not have the permission order_manage_all and should not be in the basket's users list. Maybe we should not check for order_manage_all here. What do you think ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org