[Bug 20150] New: Acquisitions wizard always uses listprice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Bug ID: 20150 Summary: Acquisitions wizard always uses listprice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When using the acquisitions wizard, you can choose between different options: - Amount: - Ordered amount: - Spent amount: The calculations are always done with listprice. Especially for the amount spent this makes the wizard not match up with the amounts on the acquisition homepage as the actual amount spent can be quite different from the list price used when ordering. I think it probably should be calculated like this: - Amount: list price of ordered items + actual price of received items - Ordered amount: list price - Spent amount: actual price -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions wizard always |Acquisitions wizard falsely |uses listprice |uses list price for | |calculating amounts spent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Maura Stephens <maura.stephens@gmit.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens@gmit.ie --- Comment #1 from Maura Stephens <maura.stephens@gmit.ie> --- Katrin, It is vital that this bug is resolved asap, and those running end of year stats need to be aware of it. Acquisitions financial data integrity is key. I will have had issued statistics for 2017, 2018 and 2019 without being aware of this problem. It is by pure chance that I noticed something for 2019 that brought this bug to my attention. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Maura, I'd love to see this fixed, but probably won't have the time tow ork on it myself. I reported this, as one of our libraries brought it to my attention - but it didn't get any attention so far. I am updating the severity a bit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 --- Comment #3 from Maura Stephens <maura.stephens@gmit.ie> --- Thanks Katrin, I've emailed some colleagues in the hope of getting a few more votes also. This is quite major for our libraries as we only use Koha Acquisitions for our full budget, and rely completely on it for accurate stats. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108105&action=edit Bug 20150: Try to fix Acquisitions wizard It is always using listprice when we need to do the same math as the acq home page. This patch is reusing the queries from GetBudgetHierarchy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Maura, this report script looks quite obsolete as it has not been updated for years. I tried to fix the different amount to match the ones we have on the acquisiton home page. Can you give it a try please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 --- Comment #6 from Maura Stephens <maura.stephens@gmit.ie> --- Hi Jonathan, Firstly on Koha Acq none of the price fields in an order record field are called 'list price' there are 'vendor price' and 'retail price' so I had to open a call with Interleaf to work out which one this is. This make it confusing for End of Year Stats I've run the Wizard reports in question again but as I had to do some investigations when I was trying to figure out what was happening here I guess it will be end 2021 when I get true figures. I've said this before to Interleaf that Annual Acq stats should be solely based on encumbrances and expenditure per annum. The reopening of baskets skewing stats is not a good feature when you have to make annual reports to Finance departments. Thanks for looking at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Maura Stephens from comment #6)
Firstly on Koha Acq none of the price fields in an order record field are called 'list price' there are 'vendor price' and 'retail price' so I had to open a call with Interleaf to work out which one this is. This make it confusing for End of Year Stats
Hi Maura, we need to do some more work to make the terminology match on all pages. :( Maybe I can help (or confuse even more) list price = vendor price (list_price in db) (first price field entered on an order) Retail price = (rrp in db) (price in active currency calculated from list price) Budgeted cost = (ecost in db) estimated price with discount etc. that the library will have to pay Actual cost = (unit_price in db) entered on receive I'll try to verify Jonathan's changes here - on first glance it does look ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, the calculation for "Amount" is not right: + } elsif ( $process == 3 ) { # Amount + $strcalc .= q|SUM(| . C4::Acquisition::get_rounding_sql(q|ecost_tax_included|) . q| * quantity ) + SUM(| . C4::Acquisition::get_rounding_sql(q|COALESCE(unitprice_tax_included, ecost_tax_included)|) . q| * quantity ) AS budget_total |; I see about double of the value I should be seening. I think this is because in case of a received order, we do add up ecost + unit_price here for the same order line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Daphne Hoolahan <dch@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org