[Bug 19366] New: PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Bug ID: 19366 Summary: PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 16275 With PatronSelfRegistrationEmailMustBeUnique set to "Consider" I am unable to submit a change to my patron record via the OPAC because Koha performs the existing-email check on the email in the existing record I'm modifying. PatronSelfRegistrationEmailMustBeUnique should only apply new registrations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67404&action=edit Bug 19366: Do not block patron's detail update if EmailMustBeUnique If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"), a patron is not allowed to register with an existing email address. The existing code is wrong and reject a patron that is updating their personal details with "This email address already exists in our database.", even if the patron did not modify their email address. This is caused by the query we made, we must search for patron with this email address but who is not the current patron. Test plan: - Set PatronSelfRegistrationEmailMustBeUnique to "consider" - Register a new patron with an existing email address => you should not be allowed - Use a non-existent email address => You should be allowed - Edit your patron details - Modify some infos => Should pass - Modify your email address with an existing one => You should not be allowed to do that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67404|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67424&action=edit Bug 19366: Do not block patron's detail update if EmailMustBeUnique If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"), a patron is not allowed to register with an existing email address. The existing code is wrong and reject a patron that is updating their personal details with "This email address already exists in our database.", even if the patron did not modify their email address. This is caused by the query we made, we must search for patron with this email address but who is not the current patron. Test plan: - Set PatronSelfRegistrationEmailMustBeUnique to "consider" - Register a new patron with an existing email address => you should not be allowed - Use a non-existent email address => You should be allowed - Edit your patron details - Modify some infos => Should pass - Modify your email address with an existing one => You should not be allowed to do that Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67424|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67442&action=edit Bug 19366: Do not block patron's detail update if EmailMustBeUnique If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"), a patron is not allowed to register with an existing email address. The existing code is wrong and reject a patron that is updating their personal details with "This email address already exists in our database.", even if the patron did not modify their email address. This is caused by the query we made, we must search for patron with this email address but who is not the current patron. Test plan: - Set PatronSelfRegistrationEmailMustBeUnique to "consider" - Register a new patron with an existing email address => you should not be allowed - Use a non-existent email address => You should be allowed - Edit your patron details - Modify some infos => Should pass - Modify your email address with an existing one => You should not be allowed to do that Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22458 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org