[Bug 10517] New: kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Bug ID: 10517 Summary: kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: John.Seymour@nal.gov.au CC: robin@catalyst.net.nz Created attachment 19284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19284&action=edit patch koha-restore kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails. It also attempts to drop the mysqluser which does not exist causing an error. Please find attached an updated version which corrects these problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Robin, could you maybe take a look at this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- I don't think removing the instruction to remove the user if it exists is a good idea, as it might be there. And it it is there, then we want to remove it. As it stands, the error coming from that failing should be ignored and the script should proceed. If that's not happening, that's a bug in and of itself (though looking at it, it should be OK.) As for adding the permission for @$mysql_hostname, I wonder if that should be fixed to 'localhost' like it is in koha-create. This is to account for connecting via either a UNIX socket or a loopback TCP connection within a machine. For situations where the mysql server is on a remote host, we're probably reaching the point of complexity where koha-restore isn't suitable in it's current form. So anyway, I think it should probably be modified such that mysql_hostname is always 'localhost', and that'll solve the zebra mysql issue. Any thoughts on this, John? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #3 from John.Seymour@nal.gov.au --- I think that as the koha-remove script drops the user and if you are restoring to a new install the user should not exist, the existence of an existing user is an error that should be flagged. As for the @$mysql_hostname I originaly had is as a static 'localhost' but as the hostname is available for the koha-conf.xml file I thought the use of this value would future proof the script. Feel free to change it back to a static if you think this is more appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org