[Bug 13052] New: OPAC Cart JavaScript is included twice in the footer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Bug ID: 13052 Summary: OPAC Cart JavaScript is included twice in the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The template logic for including the Cart's JavaScript file is doubled up in the OPAC footer include. One instance should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32085&action=edit Bug 13052 - OPAC Cart JavaScript is included twice in the footer The external JavaScript file which powers the OPAC Cart should not be included twice. The correct instance is the one which comes after the definition of MSG strings. To test you must have the opacbookbag system preference turned on. In Bootstrap OPAC, test adding some items to the Cart and confirm that Cart operations work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32085|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32297&action=edit Bug 13052 - OPAC Cart JavaScript is included twice in the footer The external JavaScript file which powers the OPAC Cart should not be included twice. The correct instance is the one which comes after the definition of MSG strings. To test you must have the opacbookbag system preference turned on. In Bootstrap OPAC, test adding some items to the Cart and confirm that Cart operations work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32297|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32312&action=edit [PASSED QA] Bug 13052 - OPAC Cart JavaScript is included twice in the footer The external JavaScript file which powers the OPAC Cart should not be included twice. The correct instance is the one which comes after the definition of MSG strings. To test you must have the opacbookbag system preference turned on. In Bootstrap OPAC, test adding some items to the Cart and confirm that Cart operations work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cart is still working as expected, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13052 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org