https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51344&action=edit Bug 16477 - Improve staff client cart JavaScript and template This patch makes several changes to the cart JavaScript and template. In the template: - Remove "onclick" attributes in favor of defining events in the JavaScript. - Add a [% BLOCK %] section for some repeated markup. - Add some Font Awesome icons (I didn't add icons to all controls because I thought it looked cluttered). - Move the batch modification control out of the toolbar and into the group of controls which affects selected records. I think this is a logical grouping, and makes more sense than having a drop-down menu in the toolbar with a single menu item. JavaScript: - Created separate "cart.js" file so that JS could be moved out of the template without loading up basket.js with event functions which are not needed on every page in the staff client. - Fix JSHint errors. To test, apply the patch and clear your browser cache if necessary. - Add multiple items to the cart in the staff client and open the cart. - Confirm correct functionality of these toolbar buttons: - "More details" (and the corresponding "Show less") - "Send" - "Print" - "Empty and close" - Confirm the correct functionality of all the selection controls: Select all, clear all, Remove, Add to a list, Place hold, Batch modify, and Batch delete. - Confirm that clicking any title in the cart opens the correct detail page in the parent window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51376|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52772&action=edit Bug 16477 - Improve staff client cart JavaScript and template This patch makes several changes to the cart JavaScript and template. In the template: - Remove "onclick" attributes in favor of defining events in the JavaScript. - Add a [% BLOCK %] section for some repeated markup. - Add some Font Awesome icons (I didn't add icons to all controls because I thought it looked cluttered). - Move the batch modification control out of the toolbar and into the group of controls which affects selected records. I think this is a logical grouping, and makes more sense than having a drop-down menu in the toolbar with a single menu item. JavaScript: - Created separate "cart.js" file so that JS could be moved out of the template without loading up basket.js with event functions which are not needed on every page in the staff client. - Fix JSHint errors. To test, apply the patch and clear your browser cache if necessary. - Add multiple items to the cart in the staff client and open the cart. - Confirm correct functionality of these toolbar buttons: - "More details" (and the corresponding "Show less") - "Send" - "Print" - "Empty and close" - Confirm the correct functionality of all the selection controls: Select all, clear all, Remove, Add to a list, Place hold, Batch modify, and Batch delete. - Confirm that clicking any title in the cart opens the correct detail page in the parent window. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=1647 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.