[Bug 20527] New: <label> linked to the wrong <input> (wrong "for" attribute)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Bug ID: 20527 Summary: <label> linked to the wrong <input> (wrong "for" attribute) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org https://gitlab.com/koha-community/Koha/blob/8538886cb91f977d6109bfd035d4d834... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|<label> linked to the wrong |<label> linked to the wrong |<input> (wrong "for" |<input> (wrong "for" |attribute) |attribute) in paycollect.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please add a test plan to explain where the problem is and how it looks like? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- This is not a functional bug it's a mistake in the HTML where a label is not well linked to the input field. Well actually there a small functional symptom. 1. Go to a patron 2. Go to Fines 3. Go to Pay fines 4. Write off an individual fine line 5. URL should be "staff://cgi-bin/koha/members/paycollect.pl?borrowernumber=9999999&writeoff_individual=999999" 6. Click on "Writeoff amount:" 7. The field is not focused. This is the bug. Linking a label and the field allow to focus the field when clicking the label. It can be also used by accessibility tools. E.g. for a screen reader a blind keyboard to tell the name of the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 --- Comment #3 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84034&action=edit Bug 20527: Made the "Writeoff amount" input focus when the "Pay fines" tab loads. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ethan.amohia@gmail.com |ity.org | CC| |ethan.amohia@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- Hi Ethan. This works for the Write off button. I think this should also be done for the other buttons as well - Pay, Pay amount, Pay selected, and Write off selected. I also noticed that for the row of buttons at the bottom (Pay, Pay amount, Pay selected, and Write off selected) when you press cancel on the individual screens that it takes you back to the Transactions tab, rather than Make a payment tab. This should probably be added as separate bug. Note that bug 18661 will fix the tab titles when you are in any of the payment and write off screens so that they stay as 'Transactions' and 'Make a payment' (currently they are labelled Account and Pay fines). I would also add an updated test plan to the bug as well (the QA team will probably ask for it!), for example: 1. Search for a patron (Patrons > Search > Select a patron) 2. Add an invoice for a patron (Accounting > Create manual invoice) 3. Before applying the patch click on any of the payment or write off buttons* (under Accounting > Make a payment) - you should notice that the tab focus is on the search patrons field at the top of the page, rather than the payment amount field 4. After applying the patch check that the tab focus for all of the payment or write off buttons* is on the payment amount field (and it should be outlined in a darker green) * Buttons for transaction line items: Pay, Write off; Buttons at the bottom: Pay, Pay amount, Pay selected, and Write off selected Setting the focus on the payment amount field allows staff to more quickly update the amount. It is also an accessibility issue, and fixing this makes navigating the pages easier for those using accessibility tools, such as screen readers. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #4)
I also noticed that for the row of buttons at the bottom (Pay, Pay amount, Pay selected, and Write off selected) when you press cancel on the individual screens that it takes you back to the Transactions tab, rather than Make a payment tab. This should probably be added as separate bug.
This can be fixed at Bug 22148. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84034|0 |1 is obsolete| | --- Comment #6 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84100&action=edit Bug 20527: Significant inputs will be focused on in the "Accounting" section of a patron. Test Plan: 1. From the homepage, select Patrons. 2. Search for any patron and select any patron. 3. You should be seeing the patrons' details. On the left, select "Accounting". 4. Click on "Pay". 5. The "Collect from patron" field should be focused. This means you should not have to click on the input field to start typing, it should already be selected. Confirm that this works. 6. Click "Cancel" and you should be back to the "Make a payment" tab. 7. Click on "Write off". 8.The "Writeoff amount" field should be focused. Confirm that this works. 9. Click "Cancel" and you should be back to the "Make a payment" tab. 10. Click on "Pay amount". 11. The "Collect from patron" field should be focused. Confirm that this works. 12. Click "Pay fines" tab and you should be back to the "Make a payment" tab. 13. Click on "Pay selected". 14. Repeat steps 12 & 13. 15. Click on "Write off selected". 16. The "Writeoff amount" field should be focused. Confirm that this works. 17. Click "Pay fines" tab and you should be back to the "Make a payment" tab. 18. Click the "Create manual invoice". 19. The "Amount" field should be focused. Confirm that this works. 20. Click on "Create manual credit". 21. The "Amount" field should be focused. Confirm that this works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 --- Comment #7 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84110&action=edit Bug 20527: Removing focus from payment note Did not mean to leave this in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84100|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 84130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84130&action=edit Bug 20527: Significant inputs will be focused on in the "Accounting" section of a patron. Test Plan: 1. From the homepage, select Patrons. 2. Search for any patron and select any patron. 3. You should be seeing the patrons' details. On the left, select "Accounting". 4. Click on "Pay". 5. The "Collect from patron" field should be focused. This means you should not have to click on the input field to start typing, it should already be selected. Confirm that this works. 6. Click "Cancel" and you should be back to the "Make a payment" tab. 7. Click on "Write off". 8.The "Writeoff amount" field should be focused. Confirm that this works. 9. Click "Cancel" and you should be back to the "Make a payment" tab. 10. Click on "Pay amount". 11. The "Collect from patron" field should be focused. Confirm that this works. 12. Click "Pay fines" tab and you should be back to the "Make a payment" tab. 13. Click on "Pay selected". 14. Repeat steps 12 & 13. 15. Click on "Write off selected". 16. The "Writeoff amount" field should be focused. Confirm that this works. 17. Click "Pay fines" tab and you should be back to the "Make a payment" tab. 18. Click the "Create manual invoice". 19. The "Amount" field should be focused. Confirm that this works. 20. Click on "Create manual credit". 21. The "Amount" field should be focused. Confirm that this works. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84110|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 84131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84131&action=edit Bug 20527: Removing focus from payment note Did not mean to leave this in. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this patch does fix the problem initially reported. Adding Owen in hope he might be able to shine some light. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- The patch doesn't address what the bug reports. The patch adds auto-focus to some accounting form fields, but some of them don't make sense: Putting the focus on the payment field only makes sense if it's the first or only field in the form. Adding focus to the *last* input in the form seems counterproductive. The auto-focus changes to paycollect.tt could be re-implemented on a new bug report, but it's not right for this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|ethan.amohia@gmail.com |eden.bacani@gmail.com CC| |eden.bacani@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84130|0 |1 is obsolete| | Attachment #84131|0 |1 is obsolete| | --- Comment #12 from Eden <eden.bacani@gmail.com> --- Created attachment 115494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115494&action=edit Bug 20527: Corrected paid to amountwrittenoff Test Plan 1. Go to My account and go into accounting 2.Create manual invoice (If you already have invoices skip this step) 3.On the Make a payment tab click on Write off under actions of an invoice 4. Click on Writeoff amount label and make sure that the amount written is highlighted in green. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115494|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115536&action=edit Bug 20527: Corrected paid to amountwrittenoff Test Plan 1. Go to My account and go into accounting 2.Create manual invoice (If you already have invoices skip this step) 3.On the Make a payment tab click on Write off under actions of an invoice 4. Click on Writeoff amount label and make sure that the amount written is highlighted in green. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115536|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115568&action=edit Bug 20527: Corrected paid to amountwrittenoff Test Plan 1. Go to My account and go into accounting 2.Create manual invoice (If you already have invoices skip this step) 3.On the Make a payment tab click on Write off under actions of an invoice 4. Click on Writeoff amount label and make sure that the amount written is highlighted in green. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115570&action=edit Bug 20527: (QA follow-up) Fix type 'Wiriteoff' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the HTML <label release notes| |for=""> element for the | |Writeoff amount field on | |the Accounting > Make a | |payment form for a patron - | |changes "paid" to | |"amountwrittenoff". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|<label> linked to the wrong |"label" tag linked to the |<input> (wrong "for" |wrong "input" tag (wrong |attribute) in paycollect.tt |"for" attribute) in | |paycollect.tt Text to go in the|This fixes the HTML <label |This fixes the HTML 'label release notes|for=""> element for the |for=""' element for the |Writeoff amount field on |Writeoff amount field on |the Accounting > Make a |the Accounting > Make a |payment form for a patron - |payment form for a patron - |changes "paid" to |changes "paid" to |"amountwrittenoff". |"amountwrittenoff". CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org