[Bug 32663] New: Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Bug ID: 32663 Summary: Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org When logged in to the OPAC and editing your personal details, you get an error trace if you enter a reasonable amount of text in the main address street number input field, for example: abcdefghijk. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'streetnumber' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm line 77 74: my $self = { msg => $msg }; 75: bless $self => $class; 76: 77: die $self; 78: } 79: 80: =head2 rethrow Show function arguments To replicate: 1. Log in to the OPAC (I used koha and koha with KTD). 2. Go to Your account > Personal details 3. Enter abcdefghijk in the Main address > Street number input field. 4. Error trace occurs. 5. Enter abcdefghij in the Main address > Street number input field. 6. Form submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 145379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145379&action=edit Bug 32663: Limit streetnumber to 10 characters in OPAC This change harmonizes the patron streetnumber input between the staff interface and the OPAC, so that you can only enter 10 characters into the streetnumber for the OPAC. Without this change, a fatal error will be thrown trying to save the too long data. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 2. Note that you can only enter 10 characters into the "Street number" field as a self-registration patron 3. Log into Koha 4. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 5. Note that you can only enter 10 characters into the "Street number" field when editing logged in patron details too 6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S 7. Note that you can only enter 10 characters into the "Street number" field as a staff member -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145379|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145381&action=edit Bug 32663: Limit streetnumber to 10 characters in OPAC This change harmonizes the patron streetnumber input between the staff interface and the OPAC, so that you can only enter 10 characters into the streetnumber for the OPAC. Without this change, a fatal error will be thrown trying to save the too long data. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 2. Note that you can only enter 10 characters into the "Street number" field as a self-registration patron 3. Log into Koha 4. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 5. Note that you can only enter 10 characters into the "Street number" field when editing logged in patron details too 6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S 7. Note that you can only enter 10 characters into the "Street number" field as a staff member Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145381|0 |1 is obsolete| | --- Comment #3 from solene.ngamga@inlibro.com --- Created attachment 145879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145879&action=edit Bug 32663: Limit streetnumber to 10 characters in OPAC This change harmonizes the patron streetnumber input between the staff interface and the OPAC, so that you can only enter 10 characters into the streetnumber for the OPAC. Without this change, a fatal error will be thrown trying to save the too long data. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 2. Note that you can only enter 10 characters into the "Street number" field as a self-registration patron 3. Log into Koha 4. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 5. Note that you can only enter 10 characters into the "Street number" field when editing logged in patron details too 6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S 7. Note that you can only enter 10 characters into the "Street number" field as a staff member Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- `streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your patron/borrower''s primary address', Are we going the right direction here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #4)
`streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your patron/borrower''s primary address',
Are we going the right direction here?
Perhaps not. Looks like borrower_modifications is out of sync with borrowers and deletedborrowers. Looks like many fields in borrower_modifications have the wrong type: streetnumber, streettype, zipcode, mobile, B_streetnumber, B_streettype, B_address, B_zipcode, password, altcontactfirstname, altcontactsurname, altcontactaddress1, altcontactaddress2, altcontactaddress3, altcontactzipcode, altcontactphone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
(In reply to Marcel de Rooy from comment #4)
`streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your patron/borrower''s primary address',
Are we going the right direction here?
Perhaps not.
Looks like borrower_modifications is out of sync with borrowers and deletedborrowers.
Looks like many fields in borrower_modifications have the wrong type: streetnumber, streettype, zipcode, mobile, B_streetnumber, B_streettype, B_address, B_zipcode, password, altcontactfirstname, altcontactsurname, altcontactaddress1, altcontactaddress2, altcontactaddress3, altcontactzipcode, altcontactphone
At least that's in kohastructure.sql. I am not sure about an upgraded database. Yikes... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the discussion about harmonizing the datatypes would be better moved elsewhere so we can proceed with this patch that brings the form in line with the form in the staff interface. A simple change that will help avoid issues for now and add to consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error updating personal |Street number should not |details in OPAC when > 10 |allow for entering more |text characters entered: |than 10 characters in OPAC |Main address > Street | |number input field | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145879|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147421&action=edit Bug 32663: Limit streetnumber to 10 characters in OPAC This change harmonizes the patron streetnumber input between the staff interface and the OPAC, so that you can only enter 10 characters into the streetnumber for the OPAC. Without this change, a fatal error will be thrown trying to save the too long data. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 2. Note that you can only enter 10 characters into the "Street number" field as a self-registration patron 3. Log into Koha 4. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 5. Note that you can only enter 10 characters into the "Street number" field when editing logged in patron details too 6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S 7. Note that you can only enter 10 characters into the "Street number" field as a staff member Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 [Bug 25590] B_streetnumber is missing from opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25590 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 [Bug 25590] B_streetnumber is missing from opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.11 |23.05.00,22.11.04,22.05.11, released in| |21.11.19 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org