[Bug 36030] New: Cannot cancel or remove orders referring to deleted biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Bug ID: 36030 Summary: Cannot cancel or remove orders referring to deleted biblio records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Looking at late orders, we still have some orders that are "open" but they relate to deleted bibliographic records. It is not clear anymore how that exactly happened. I can only "Edit" the order (change delivery date). But I just want to cleanup here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Similarly: How to reproduce this, not clear now. But I have quite a bunch of orders that have no biblionumber, no deleted biblionumber, orderstatus ordered and a filled datecancellationprinted. The system only allows you to edit the delivery date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, this is a duplicate I think - there are multiple issues with deleted records and acquisition orders. I'd love to work together on solving these. The way to create a problem goes like this: * Order something, receive it, etc. * Delete the bibliographic record from the catalog. Until bug 33262 that created entries in aqorders with no biblionumber left. Now we keep the connection with a new column deleted_biblionumber, but we are not making use of it yet. For other bugs see: * Bug 10869 - Can't cancel order line if title deleted * Bug 10758 - Show bibliographic information of deleted records in acquisitions * Bug 27893 - Delete of biblio with order does not always warn I believe we cannot tell people to not delete records, because items bought might also be removed from the library at one point, but we still need to allow the library to keep track of these for accounting/auditing purposes on how money was spent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I thought that I saw an orderline with date cancellation too in the first table. But I cant reproduce.. Code seems to be fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Another observation: Open basket, order with deleted biblio. Can place a hold on that record!? The link contains no biblionumber.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
Another observation: Open basket, order with deleted biblio. Can place a hold on that record!? The link contains no biblionumber..
https://master.rijkskoha.nl:28443/cgi-bin/koha/reserve/request.pl?biblionumb... Fun -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #3)
I thought that I saw an orderline with date cancellation too in the first table. But I cant reproduce.. Code seems to be fine.
We have seen this with orders in any state. I think it's always possible to overwrite the warning and delete the bibliopgrahic record somehow. Maybe also need to think of batch record deletion/batch item deletion with 'delete record' checkbox set. (In reply to Marcel de Rooy from comment #5)
(In reply to Marcel de Rooy from comment #4)
Another observation: Open basket, order with deleted biblio. Can place a hold on that record!? The link contains no biblionumber..
https://master.rijkskoha.nl:28443/cgi-bin/koha/reserve/request. pl?biblionumber=
Fun
I'd say this is a separate bug to report, but overall we need better handling for the "deleted record" case. Did you see the earlier comment and bugs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161884&action=edit Bug 36030: acqui/basket: Do not place hold on deleted biblio Trivial fix. Test plan: Find a deleted biblio record in ACQ (in active orders part) and verify that there is no Place hold option on that row. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
Another observation: Open basket, order with deleted biblio. Can place a hold on that record!? The link contains no biblionumber..
Added a fix for this now along the way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #6)
Did you see the earlier comment and bugs?
Yes, thanks! Added few comments on the 10869. Awaiting comments there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10869 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Summary|Cannot cancel or remove |Do not show "Place hold" |orders referring to deleted |for deleted biblio record |biblio records |on basket page --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Okay. I am changing title here. The original 36030 is a duplicate. Continue that discussion on 10869. I am moving this one to "Do not show Place hold for deleted biblio". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is a very trivial patch. Self SO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161884|0 |1 is obsolete| | --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 163724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163724&action=edit Bug 36030: acqui/basket: Do not place hold on deleted biblio Trivial fix. Test plan: Find a deleted biblio record in ACQ (in active orders part) and verify that there is no Place hold option on that row. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36030 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org