[Bug 20101] New: Cronjob automatic_item_modification_by_age.pl does not log run in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Bug ID: 20101 Summary: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71064&action=edit Bug 20101 - Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71064|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71068&action=edit Bug 20101 - Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs NOTE: Create rule in tools! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71069&action=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71069|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71070&action=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #5 from George Williams (NEKLS) <george@nekls.org> --- *** Bug 20095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the logs the interface is shown as 'opac', should this not be command-line? Otherwise patches work ok, but please fix the patch subjects to match: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |11023 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71068|0 |1 is obsolete| | Attachment #71070|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102652&action=edit Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102653&action=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Looking at the logs the interface is shown as 'opac', should this not be command-line?
The interface is labeled as 'cron' in my testing, and is not modified by this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- C4::Context::clear_syspref_cache; I think there should be no need to do such thing here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- * Commit title does not contain 'follow-up' correctly spelt - ef873f25fb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102809&action=edit Bug 20101: Follow-up - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102810&action=edit Bug 20101: Follow-up - No need to clear syspref cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- IMO the 2 follow-ups do not belong to this bug report. I would obsolete them, then PQA/push that first patch that waited for too long already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102652|0 |1 is obsolete| | Attachment #102809|0 |1 is obsolete| | Attachment #102810|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103118&action=edit Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)
IMO the 2 follow-ups do not belong to this bug report. I would obsolete them, then PQA/push that first patch that waited for too long already.
Agreed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This sort of feels like something that could move into the Koha::Script base class at some point.. however not here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org